Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of duplicate bin names in DQM/L1TMonitor #39853

Merged
merged 2 commits into from Oct 26, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

ROOT appears to be enforcing that user defined bin names for histograms must be unique.
This fixes the failures in the integration builds of workflow 4.6.

PR validation:

Now when running workflow 4.6 step3 the jobs succeed.

This is needed to avoid a ROOT error while merging during
harvesting.
This avoids a ROOT error during harvesting.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39853/32734

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test with workflow 4.6

@perrotta
Copy link
Contributor

please test workflow 4.6

@perrotta
Copy link
Contributor

urgent

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-542f14/28510/summary.html
COMMIT: 1003743
CMSSW: CMSSW_12_6_X_2022-10-25-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39853/28510/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
4.6 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-542f14/4.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3384029
  • DQMHistoTests: Total failures: 93
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3383914
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 204 log files, 48 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

@cms-sw/dqm-l2 could you please review this PR, and also sign if you agree with it?

@perrotta
Copy link
Contributor

+1

  • Bypassing the dqm signature, in order to have this fix into 12_6_0_pre4 that we plan to build by tomorrow
  • @cms-sw/dqm-l2 please complain if there is anything you don't like here: this can still get reverted after pre4

@perrotta
Copy link
Contributor

merge

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants