Fix remaining CMS deprecation warnings in Reco* subsystems

[Dr15Jones]

PR description:

• converted modules to thread-friendly types
• added missing esConsumes

PR validation:

Code compiles without issuing CMS deprecation warnings.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39878/32800

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoEgamma/EgammaElectronProducers/test/GEDValueMapAnalyzer.cc modified in PR(s): Fix CMS deprecation warnings in RecoEgamma subsystem #39801
  • File RecoEgamma/EgammaIsolationAlgos/test/TestEgammaTowerIso.cc modified in PR(s): Fix CMS deprecation warnings in RecoEgamma subsystem #39801

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• RecoCaloTools/Selectors (reconstruction)
• RecoEcal/EgammaCoreTools (reconstruction)
• RecoEgamma/EgammaElectronProducers (reconstruction)
• RecoEgamma/EgammaIsolationAlgos (reconstruction)
• RecoHI/HiEgammaAlgos (reconstruction)
• RecoParticleFlow/PFClusterTools (reconstruction)
• RecoParticleFlow/PFProducer (reconstruction)
• RecoPixelVertexing/PixelLowPtUtilities (reconstruction)
• RecoTBCalo/EcalSimpleTBAnalysis (reconstruction)
• RecoTBCalo/ZDCTBAnalysis (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @jainshilpi, @argiro, @thomreis, @Prasant1993, @varuns23, @seemasharmafnal, @mmarionncern, @JanFSchulte, @lgray, @missirol, @yenjie, @simonepigazzini, @mandrenguyen, @yetkinyilmaz, @Sam-Harper, @kurtejung, @GiacomoSguazzoni, @rovere, @VinInn, @hatakeyamak, @mmusich, @mtosi, @dgulhan, @rchatter, @valsdav, @jazzitup, @sobhatta, @lecriste, @afiqaize, @wrtabb, @sameasy, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f36d0/28576/summary.html
COMMIT: c6a2e54
CMSSW: CMSSW_12_6_X_2022-10-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39878/28576/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3384029
• DQMHistoTests: Total failures: 99
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3383908
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

• technical PR
• no reco changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

• Technical