Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted remaining DQM modules to edm::one::EDAnalyzer #39888

Merged
merged 1 commit into from Nov 2, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This fixes the CMS deprecation warnings in the DQM subsystem.

PR validation:

Packages compile without issuing CMS deprecation warnings.

This fixes the CMS deprecation warnings in the DQM subsystem.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39888/32808

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • DQM/BeamMonitor (dqm, db)
  • DQM/EcalMonitorDbModule (dqm)
  • DQM/HLTEvF (dqm, hlt)
  • DQM/SiStripCommissioningClients (dqm)
  • DQM/SiStripCommissioningSources (dqm)
  • DQM/TrigXMonitorClient (dqm)

@malbouis, @Martin-Grunewald, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @missirol, @jfernan2, @saumyaphor4252, @syuvivida, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@erikbutz, @rchatter, @mtosi, @argiro, @missirol, @silviodonato, @thomreis, @simonepigazzini, @mmusich, @threus, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-883f36/28585/summary.html
COMMIT: 8a78bd0
CMSSW: CMSSW_12_6_X_2022-10-27-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39888/28585/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3384029
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3383998
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@tvami
Copy link
Contributor

tvami commented Oct 31, 2022

+db

  • quoting Matti, "solution in a suboptimal way though, that does not use DQM base classes and prevents concurrent lumis"
  • but it is a solution, and we can let the beampost team deal with it in a more optimal way later

@mmusich
Copy link
Contributor

mmusich commented Oct 31, 2022

quoting Matti, "solution in a suboptimal way though, that does not use DQM base classes and prevents concurrent lumis"

please open an issue about it, otherwise it gets difficult to track it down.

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

+1

@mmusich
Copy link
Contributor

mmusich commented Nov 3, 2022

please open an issue about it, otherwise it gets difficult to track it down.

I've done it here: #39973 (for the record)

@Dr15Jones Dr15Jones deleted the deprecatedDQM branch November 4, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants