Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GE21 recHits in GEM onlineDQM, a backport to 12_4_X #39890

Merged

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Oct 28, 2022

PR description:

With this PR GE21 recHits are generated and drawn in the GEM onlineDQM. It makes effect only on the onlineDQM system, not on any other places, such as muon reconstruction.

PR validation:

Test are done with cmsRun $CMSSW_RELEASE_BASE/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #39860 to 12_4_X.

@jshlee @watson-ij @seungjin-yang

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2022

A new Pull Request was created by @quark2 for CMSSW_12_4_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #39860

@emanueleusai
Copy link
Member

please test

@emanueleusai
Copy link
Member

testing at p5

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90a868/28729/summary.html
COMMIT: af170b4
CMSSW: CMSSW_12_4_X_2022-11-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39890/28729/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3719758
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3719710
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

test at p5 successful

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

  • Simple configuration change

@cmsbuild cmsbuild merged commit 68a6888 into cms-sw:CMSSW_12_4_X Nov 3, 2022
@quark2
Copy link
Contributor Author

quark2 commented Nov 7, 2022

Hi @emanueleusai,

Sorry for my late request. Could you deploy this PR to P5?

@emanueleusai
Copy link
Member

this should be online already. Are you seeing any issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants