Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nano: fix matching between pat trigger objects and L1 objects #39893

Merged
merged 1 commit into from Oct 28, 2022

Conversation

swertz
Copy link
Contributor

@swertz swertz commented Oct 28, 2022

PR description:

Fix bug with matching between PAT trigger objects and L1 objects reported in #39809.

PR validation:

Ran with runTheMatrix.py --what nano --site "" --command "--number 10". Differences in trigger object L1/L2 branches are expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Will backport to 124X. Similarly to #39309, #39230 and #39818, this will introduce some differences wrt previously produced nanoV10 samples (both when running in 126X and 124X), but we (XPOG) think the gain of fixing those in prompt nano outweights the cost of introducing these differences. Further, more cleanup on the TriggerObjectTableProducer is planned.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39893/32811

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swertz (Sébastien Wertz) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor Author

swertz commented Oct 28, 2022

enable nano

@swertz
Copy link
Contributor Author

swertz commented Oct 28, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59ec10/28590/summary.html
COMMIT: 6eeb9dd
CMSSW: CMSSW_12_6_X_2022-10-27-2300/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39893/28590/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3384029
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3383974
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.001_data80X+MuonEG2016HMINIAOD8.0+NANO_data8.0+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.0_mc80X+TTbarMINIAOD8.0+NANO_mc8.0+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.101_mc94Xv2+TTbarMINIAOD9.4v2+NANO_mc9.4v2+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.11_data94X2016+MuonEG2016MINIAOD9.4v2+NANO_2016data9.4v2+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.12_data94Xv2+MuonEG2017MINIAOD9.4v2+NANO_data9.4v2+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.1_mc94X2016+TTbar2016MINIAOD9.4v2+NANO_2016mc9.4v2+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.21_data102X+MuonEG2018MINIAOD10.2+NANO_data10.2+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.2_mc102X+TTbarMINIAOD10.2+NANO_mc10.2+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.301_mc106Xul17+TTbarMINIAOD10.6_UL17v1+NANO_mc10.6ul17v1+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.302_mc106Xul18+TTbarMINIAOD10.6_UL18v1+NANO_mc10.6ul18v1+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.311_mc106Xul17v2+TTbarMINIAOD10.6_UL17v2+NANO_mc10.6ul17v2+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.312_mc106Xul17v2+TTbarMINIAOD10.6_UL18v2+NANO_mc10.6ul18v2+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.31_mc106Xul17v2+TTbarMINIAOD10.6_UL16v2+NANO_mc10.6ul16v2+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.321_data106Xul17+MuonEG2017MINIAOD10.6v1+NANO_data10.6ul17v1+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.322_data106Xul18+MuonEG2018MINIAOD10.6v1+NANO_data10.6ul18v1+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.32_data106Xul16+MuonEG2016MINIAOD10.6v1+NANO_data10.6ul16v1+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.331_data106Xul17v2+MuonEG2017MINIAOD10.6v2+NANO_data10.6ul17v2+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.332_data106Xul18v2+MuonEG2018MINIAOD10.6v2+NANO_data10.6ul18v2+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.33_data106Xul16v2+MuonEG2016MINIAOD10.6v2+NANO_data10.6ul16v2+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.3_mc106Xul16+TTbarMINIAOD10.6_UL16v1+NANO_mc10.6ul16v1+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.401_mc122Xrun3+TTbarMINIAOD12.2+NANO_mc12.2+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.4_mc122Xrun3_v10+TTbarMINIAOD12.2+NANO_mc12.2_v10+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.501_mc124Xrun3+TTbarMINIAOD12.4+NANO_mc12.4+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.511_data124Xrun3+MuonEG2022MINIAOD12.4+NANO_data12.4+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.51_data124Xrun3_v10+MuonEG2022MINIAOD12.4+NANO_data12.4_v10+HRV_NANO_data
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.5_mc124Xrun3_v10+TTbarMINIAOD12.4+NANO_mc12.4_v10+HRV_NANO_mc
  • /pool/condor/dir_48703/jenkins/workspace/compare-root-files-short-matrix/data/PR-59ec10/2500.6_mc126X_v10+TTBarMINIAOD12.6+NANO_mc12.6_v10+HRV_NANO_mc

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 28879
  • DQMHistoTests: Total failures: 393
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 28486
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 66 log files, 0 edm output root files, 29 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.168 2.165 0.003 ( +0.1% ) 7.05 6.93 +1.7% 1.370 1.338
2500.001 1.127 1.126 0.001 ( +0.1% ) 10.21 10.06 +1.5% 1.362 1.303
2500.1 2.295 2.291 0.003 ( +0.2% ) 5.39 5.25 +2.7% 1.746 1.647
2500.101 2.349 2.346 0.004 ( +0.2% ) 4.53 4.45 +1.8% 1.896 1.741
2500.11 1.219 1.219 0.001 ( +0.1% ) 8.34 8.06 +3.4% 1.578 1.446
2500.12 1.318 1.318 0.000 ( +0.0% ) 6.08 5.94 +2.4% 1.774 1.628
2500.2 2.192 2.189 0.003 ( +0.1% ) 5.32 5.24 +1.4% 1.870 1.704
2500.21 1.208 1.208 0.000 ( +0.0% ) 7.82 7.65 +2.2% 1.733 1.657
2500.3 2.350 2.347 0.003 ( +0.1% ) 5.18 5.09 +1.8% 1.718 1.632
2500.301 2.458 2.452 0.005 ( +0.2% ) 4.63 4.61 +0.5% 1.497 1.426
2500.302 2.408 2.404 0.004 ( +0.2% ) 4.81 4.73 +1.7% 1.785 1.691
2500.31 2.235 2.232 0.003 ( +0.1% ) 8.90 8.65 +2.9% 1.437 1.388
2500.311 2.325 2.322 0.003 ( +0.1% ) 8.33 8.28 +0.7% 1.798 1.790
2500.312 2.275 2.272 0.004 ( +0.2% ) 8.57 8.34 +2.7% 1.795 1.774
2500.32 1.086 1.085 0.000 ( +0.0% ) 8.97 8.77 +2.3% 1.575 1.408
2500.321 1.454 1.453 0.001 ( +0.1% ) 5.99 5.86 +2.2% 1.776 1.625
2500.322 1.226 1.225 0.001 ( +0.0% ) 7.46 7.39 +0.9% 1.498 1.498
2500.33 1.100 1.099 0.000 ( +0.0% ) 19.62 19.55 +0.3% 1.466 1.467
2500.331 1.390 1.389 0.001 ( +0.0% ) 14.73 14.47 +1.7% 1.623 1.625
2500.332 1.316 1.316 0.000 ( +0.0% ) 16.39 16.16 +1.4% 1.559 1.559
2500.4 2.112 2.109 0.003 ( +0.1% ) 9.72 9.62 +1.1% 1.336 1.303
2500.401 2.112 2.109 0.003 ( +0.1% ) 9.76 9.68 +0.8% 1.313 1.341
2500.5 0.302 0.302 0.000 ( +0.0% ) 50.67 48.72 +4.0% 1.182 1.173
2500.501 0.302 0.302 0.000 ( +0.0% ) 49.75 48.30 +3.0% 1.189 1.196
2500.51 1.080 1.080 0.000 ( +0.0% ) 27.14 27.05 +0.3% 1.302 1.301
2500.511 1.080 1.080 0.000 ( +0.0% ) 27.96 28.29 -1.2% 1.344 1.365
2500.6 1.371 1.366 0.004 ( +0.3% ) 23.56 23.60 -0.2% 1.128 1.092
2500.601 1.371 1.367 0.005 ( +0.3% ) 23.80 23.84 -0.1% 1.176 1.173

@swertz
Copy link
Contributor Author

swertz commented Oct 28, 2022

+1

Only differences are seen in trigObj L1/L2 variables, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants