New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex144 Avoid compilation warnings in RecoParticleFlow/PFProducer test codes #39923
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39923/32839
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39923/32840
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-719aab/28625/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
@bsunanda I appreciate that you made this change. Unfortunately, the Core team has already submitted pull requests to change all legacy EDAnalyzer to a thread friendly version. Perhaps it would be best to wait a week to see if anything was missed. |
Thanks Chris. While modifying HcalDDDConstant to address the issue you referred to I cam across 2 files which violated your prescription, I acted on them without realizing tat this has been already taen care of. I shall wait for a week and if they are already tae care of I shall close those PR's
…________________________________
From: Chris Jones ***@***.***
Sent: 31 October 2022 14:19
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run3-gex144 Avoid compilation warnings in RecoParticleFlow/PFProducer test codes (PR #39923)
@bsunanda<https://github.com/bsunanda> I appreciate that you made this change. Unfortunately, the Core team has already submitted pull requests to change all legacy EDAnalyzer to a thread friendly version. Perhaps it would be best to wait a week to see if anything was missed.
—
Reply to this email directly, view it on GitHub<#39923 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOVAHC7CL2QEUEWTOVTWF7BNJANCNFSM6AAAAAARRVJB7U>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @bsunanda , what is the plan for this PR? From @Dr15Jones comment, it is not clear to me if the PR should be closed. |
@clacaputo I believe this PR contains changes beyond what I did. The way I suggest to proceed is to first rebase this PR into the master and then see what changes remain. |
Thanks @Dr15Jones . @bsunanda could you please rebase? |
I shall try. Best regards. Sunanda
…________________________________
From: Claudio Caputo ***@***.***
Sent: 14 November 2022 14:52
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run3-gex144 Avoid compilation warnings in RecoParticleFlow/PFProducer test codes (PR #39923)
Thanks @Dr15Jones<https://github.com/Dr15Jones> . @bsunanda<https://github.com/bsunanda> could you please rebase?
—
Reply to this email directly, view it on GitHub<#39923 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOVF5I4WGUX2DPUFZSTWII73DANCNFSM6AAAAAARRVJB7U>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39923/33112
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39923/33113
|
Pull request #39923 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-719aab/29151/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Avoid compilation warnings in RecoParticleFlow/PFProducer test codes
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special