Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Nano: fix matching between pat trigger objects and L1 objects #39932

Merged

Conversation

swertz
Copy link
Contributor

@swertz swertz commented Oct 31, 2022

PR description:

Fix bug with matching between PAT trigger objects and L1 objects reported in #39809.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39893

This will introduce some differences wrt previously produced nanoV10 samples in 124X, but we (XPOG) think the gain of fixing those in prompt nano outweights the cost of introducing these differences.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2022

A new Pull Request was created by @swertz (Sbastien Wertz) for CMSSW_12_4_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor Author

swertz commented Oct 31, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aebb7/28672/summary.html
COMMIT: 866fed3
CMSSW: CMSSW_12_4_X_2022-10-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39932/28672/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3682416
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3682350
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

backport of #39893

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

@swertz please prepare also a backport for the intermediate cycle 12_5_X

@swertz
Copy link
Contributor Author

swertz commented Nov 2, 2022

@swertz please prepare also a backport for the intermediate cycle 12_5_X

Is this really needed given that there will not be a re-nano in 12_5_X?

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

@swertz please prepare also a backport for the intermediate cycle 12_5_X

Is this really needed given that there will not be a re-nano in 12_5_X?

Why not? If we even decide to re-nano in 12_5_X we can easily forget that the fix, present in previous and past cycles, is missing there. Since it costs almost nothing, I would prefere not to let holes in the release cycles.

@swertz
Copy link
Contributor Author

swertz commented Nov 2, 2022

+xpog

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

+1

@cmsbuild cmsbuild merged commit c637226 into cms-sw:CMSSW_12_4_X Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants