New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to run smearing sequence separate from GEN step #39965
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39965/32896
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@cmsbuild, @perrotta, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test I don't think test will show anything except we invent a workflow to use pgen_only and pgen_smear separately. |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
@cmsbuild please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2167e2/28856/summary.html Comparison SummarySummary:
|
@cms-sw/generators-l2 @perrotta @rappoccio please let me know if you think adding a test workflow would be useful. |
+1 Discussed in ORP, will merge here and then wait for IBs before back ports. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Following the presentation on GEN-only samples for Computing at O&C meeting https://indico.cern.ch/event/1212283/, this PR proposes the mininal addition to allow to run gen and smearing separately. Basically, we need
unsmeared
collection from GEN-only step, and feed it to smearing step. (part of the cmsDriver. We may create eventcontent for this)The test with following cmsDriver runs fine, but validation/comments from GEN experts are needed to confirm this possibility.
PR validation:
Run with the following cmsDriver:
(1) Run genonly, keep transient
unsmeared
collection. I choose the processName to be GENONLY, so that we can use GEN in later step.cmsDriver.py TTbar_14TeV_TuneCP5_cfi -s GEN:pgen_genonly -n 50 --conditions auto:phase2_realistic_T21 --beamspot HLLHC14TeV --datatier GEN --eventcontent GEN --geometry Extended2026D88 --era Phase2C17I13M9 --python step0_cfg.py --nThreads 8 --nStreams=3 --no_exec --fileout file:step0.root --customise_commands "from IOMC.RandomEngine.RandomServiceHelper import RandomNumberServiceHelper ; randSvc = RandomNumberServiceHelper(process.RandomNumberGeneratorService) ; randSvc.populate() \n process.source.firstLuminosityBlock = cms.untracked.uint32(55555)" --mc --processName GENONLY --outputCommands "keep *"
(2) Run smearing+later sequence
cmsDriver.py -s GEN:pgen_smear,SIM -n 50 --conditions auto:phase2_realistic_T21 --beamspot HLLHC14TeV --datatier GEN-SIM --eventcontent RAWSIM --geometry Extended2026D88 --era Phase2C17I13M9 --python step1_cfg.py --nThreads 8 --nStreams=3 --no_exec --fileout file:step0.root --customise_commands "from IOMC.RandomEngine.RandomServiceHelper import RandomNumberServiceHelper ; randSvc = RandomNumberServiceHelper(process.RandomNumberGeneratorService) ; randSvc.populate()" --mc --filein file:step0.root --fileout file:step1.root
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be decide after we converge on this PR.