Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run smearing sequence separate from GEN step #39965

Merged
merged 1 commit into from Nov 8, 2022

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Nov 2, 2022

PR description:

Following the presentation on GEN-only samples for Computing at O&C meeting https://indico.cern.ch/event/1212283/, this PR proposes the mininal addition to allow to run gen and smearing separately. Basically, we need

  • a sequence of smearing + later tasks (this PR)
  • to keep transient unsmeared collection from GEN-only step, and feed it to smearing step. (part of the cmsDriver. We may create eventcontent for this)

The test with following cmsDriver runs fine, but validation/comments from GEN experts are needed to confirm this possibility.

PR validation:

Run with the following cmsDriver:

(1) Run genonly, keep transient unsmeared collection. I choose the processName to be GENONLY, so that we can use GEN in later step.
cmsDriver.py TTbar_14TeV_TuneCP5_cfi -s GEN:pgen_genonly -n 50 --conditions auto:phase2_realistic_T21 --beamspot HLLHC14TeV --datatier GEN --eventcontent GEN --geometry Extended2026D88 --era Phase2C17I13M9 --python step0_cfg.py --nThreads 8 --nStreams=3 --no_exec --fileout file:step0.root --customise_commands "from IOMC.RandomEngine.RandomServiceHelper import RandomNumberServiceHelper ; randSvc = RandomNumberServiceHelper(process.RandomNumberGeneratorService) ; randSvc.populate() \n process.source.firstLuminosityBlock = cms.untracked.uint32(55555)" --mc --processName GENONLY --outputCommands "keep *"

(2) Run smearing+later sequence
cmsDriver.py -s GEN:pgen_smear,SIM -n 50 --conditions auto:phase2_realistic_T21 --beamspot HLLHC14TeV --datatier GEN-SIM --eventcontent RAWSIM --geometry Extended2026D88 --era Phase2C17I13M9 --python step1_cfg.py --nThreads 8 --nStreams=3 --no_exec --fileout file:step0.root --customise_commands "from IOMC.RandomEngine.RandomServiceHelper import RandomNumberServiceHelper ; randSvc = RandomNumberServiceHelper(process.RandomNumberGeneratorService) ; randSvc.populate()" --mc --filein file:step0.root --fileout file:step1.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be decide after we converge on this PR.

@cmsbuild cmsbuild added this to the CMSSW_12_6_X milestone Nov 2, 2022
@srimanob srimanob changed the title first try Allow to run smearing sequence separate from GEN step Nov 2, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39965/32896

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/Applications (operations)
  • Configuration/StandardSequences (operations)

@cmsbuild, @perrotta, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob srimanob marked this pull request as draft November 2, 2022 18:37
@srimanob srimanob marked this pull request as ready for review November 2, 2022 18:38
@srimanob
Copy link
Contributor Author

srimanob commented Nov 7, 2022

@cmsbuild please test

I don't think test will show anything except we invent a workflow to use pgen_only and pgen_smear separately.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2167e2/28836/summary.html
COMMIT: 406c7e0
CMSSW: CMSSW_12_6_X_2022-11-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39965/28836/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416402
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416371
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Nov 7, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2167e2/28847/summary.html
COMMIT: 406c7e0
CMSSW: CMSSW_12_6_X_2022-11-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39965/28847/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416402
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416374
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Nov 8, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2167e2/28856/summary.html
COMMIT: 406c7e0
CMSSW: CMSSW_12_6_X_2022-11-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39965/28856/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416402
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416374
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Nov 8, 2022

@cms-sw/generators-l2 @perrotta @rappoccio please let me know if you think adding a test workflow would be useful.

@rappoccio
Copy link
Contributor

+1

Discussed in ORP, will merge here and then wait for IBs before back ports.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants