Updates on GE21 online/offlineDQM plots with division on modules

[quark2]

PR description:

This PR provides massive updates on GE21 onlineDQM/offlineDQM plots. This work is focusing on the division of GE21 information by modules (M1-M4). It is necessary because of the electronic configuration of GE21 chambers.

It is also included that the module information is propagated to the GEM unpacker in a better way, which is done by @yeckang.

PR validation:

Tests are done with cmsRun $CMSSW_RELEASE_BASE/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True runNumber=361054 dataset=/ExpressPhysics/Run2022F-Express-v1/FEVT and runTheMatrix.py -l limited -i all --ibeos since it makes effects on P5 and reconstruction

@jshlee @watson-ij @seungjin-yang @yeckang

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39985/32912

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @quark2 for master.

It involves the following packages:

• DQM/GEM (dqm)
• DataFormats/GEMDigi (upgrade, simulation)
• EventFilter/GEMRawToDigi (reconstruction)

@civanch, @clacaputo, @mandrenguyen, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @jshlee, @rovere, @eyigitba, @Martin-Grunewald, @missirol, @watson-ij, @trtomei, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8c71/28802/summary.html
COMMIT: f61fc9e
CMSSW: CMSSW_12_6_X_2022-11-04-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39985/28802/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416402
• DQMHistoTests: Total failures: 48
• DQMHistoTests: Total nulls: 148
• DQMHistoTests: Total successes: 3416184
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -11918.108 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -1.219 KiB GEM/Digis
• DQMHistoSizes: changed ( 11634.0,... ): -34.328 KiB GEM/Digis
• DQMHistoSizes: changed ( 11634.0,... ): 2.953 KiB GEM/DAQStatus
• DQMHistoSizes: changed ( 11634.0,... ): 0.914 KiB GEM/EventInfo
• DQMHistoSizes: changed ( 11634.0,... ): -0.094 KiB GEM/RecHits
• DQMHistoSizes: changed ( 20834.0,... ): -1958.438 KiB GEM/Digis
• DQMHistoSizes: changed ( 20834.0,... ): 9.281 KiB GEM/DAQStatus
• DQMHistoSizes: changed ( 20834.0,... ): -2.500 KiB GEM/RecHits
• DQMHistoSizes: changed ( 20834.0,... ): 1.969 KiB GEM/EventInfo
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

• plenty of changes in GEM/Digis and GEM/RecHits DQM plots, as expected

[emanueleusai]

you can proceed with the backports if you need this online

[civanch]

+1

[clacaputo]

you can proceed with the backports if you need this online

As for #39489 , this PR touches data format and can't be integrated into a closed release such as 124X and 125X

[emanueleusai]

@clacaputo thank you for the reminder. We (DQM) can deploy off-release PRs to our online systems. So if the authors want to see the new plots in online DQM we need backports to 12_4 (for online pp collisions) and 12_5 (for HI collisions). This makes is easy for us to merge the PRs with the official releases (only!) in our P5 machines, test the backports and properly keep tabs on the PRs installed.
We do not ask the backports to be merged in GitHub, instead we put the PRs on hold indefinitely. This has been done in the past for others GEM PRs.

[quark2]

Hi, @emanueleusai,

You mean, if the backport PRs to 124X and 125X are fine, then they could be deployed to P5 without merge, right?

[emanueleusai]

@quark2 from the point of view of DQM, yes we can do that

[clacaputo]

+reconstruction

[srimanob]

@cmsbuild please test

Just re-trigger the test after a week.

[srimanob]

+Upgrade

From upgrade related package, the update on header files and classes_def are minimal.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8c71/29251/summary.html
COMMIT: f61fc9e
CMSSW: CMSSW_12_6_X_2022-11-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39985/29251/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417239
• DQMHistoTests: Total failures: 48
• DQMHistoTests: Total nulls: 148
• DQMHistoTests: Total successes: 3417021
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -11918.108 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -1.219 KiB GEM/Digis
• DQMHistoSizes: changed ( 11634.0,... ): -34.328 KiB GEM/Digis
• DQMHistoSizes: changed ( 11634.0,... ): 2.953 KiB GEM/DAQStatus
• DQMHistoSizes: changed ( 11634.0,... ): 0.914 KiB GEM/EventInfo
• DQMHistoSizes: changed ( 11634.0,... ): -0.094 KiB GEM/RecHits
• DQMHistoSizes: changed ( 20834.0,... ): -1958.438 KiB GEM/Digis
• DQMHistoSizes: changed ( 20834.0,... ): 9.281 KiB GEM/DAQStatus
• DQMHistoSizes: changed ( 20834.0,... ): -2.500 KiB GEM/RecHits
• DQMHistoSizes: changed ( 20834.0,... ): 1.969 KiB GEM/EventInfo
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[syuvivida]

Hello,
sorry we would like to check if this PR went into any later 12_6_X release. This PR is merged to the master branch on November 26 but somehow it is not yet in 12_6_2. Thanks!!