Implementation of digitizer noise occupancy

[suchandradutta]

PR description:

Implementation of noise occupancy in neighboring channels without containing signal Hits for strip like modules (PSS,SS) in the Phase2 Outer Tracker. The threshold cutoff for PSS and SS modules are updated to 4800e and 6000e respectively. Corresponding noise values are set as 1010e and 1263e considering the threshold to be 4.75sigmas. The add_noisy_cell method has been updated to use this cutoff. Other than this change,

• we have switched off threshold smearing in all types of modules.
• at the moment the configuration parameter ReadoutNoiseInElec is not used and kept with a dummy value for the time being

PR validation:

The performance were presented in Phase2 Tracker Simulation meetings
https://indico.cern.ch/event/1201188/contributions/5095554/attachments/2528800/4350459/Phase2Digitizer_Noise_occupancy_14102022.pdf

https://indico.cern.ch/event/1201186/contributions/5051043/attachments/2510200/4314408/Phase2Digitizer_Noise_occupancy_16092022.pdf

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39989/32918

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for master.

It involves the following packages:

• SimTracker/SiPhase2Digitizer (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@beaucero, @VourMa, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @trtomei, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[civanch]

@suchandradutta , should this value be in the list of parameters?, is it const or may be era dependent?

[suchandradutta]

@civanch this is not era dependent. This a very large sigma value (somewhat arbitrary) to protect the add_noisy_cells function when the channel noise is zero.

[civanch]

@suchandradutta , PR needs some description.

[suchandradutta]

@suchandradutta , PR needs some description.
Sorry! I did add the comment but somehow it did not show up. Added it again now

[civanch]

please test

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13ff9d/28899/summary.html
COMMIT: b34f540
CMSSW: CMSSW_12_6_X_2022-11-08-2000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39989/28899/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11199 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416402
• DQMHistoTests: Total failures: 4852
• DQMHistoTests: Total nulls: 14
• DQMHistoTests: Total successes: 3411514
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: found differences in 3 / 46 workflows

[civanch]

+1

there is some changes in upgrade WFs , which should be expected if the noise sampling is changed.

[srimanob]

+Upgrade

Note to @cms-sw/pdmv-l2, we should see its effect in the validation.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

Minimal code changes, mostly updates to constants, PDMV should keep an eye on these in validation.