Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_5_X] Use ppEra_Run3_pp_on_PbPb_approxSiStripClusters for hi_run in visualization DQM clients #40016

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #40015

This PR updates the visualization DQM clients to use the ppEra_Run3_pp_on_PbPb_approxSiStripClusters scenario
(introduced in #39998) for the hi_run case for Run 3.

PR validation:

None - to be tested live in P5 on the playback system by @cms-sw/dqm-l2.

Backport:

Backport of #40015

@francescobrivio
Copy link
Contributor Author

backport of #40015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_5_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio
Copy link
Contributor Author

urgent

  • ideally for next 12_5_X release for HI data-taking (but can be also applied live online in DQM if it's too late to include this in a release)

@cmsbuild cmsbuild added the urgent label Nov 8, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d4c4a/28877/summary.html
COMMIT: b4b4c1c
CMSSW: CMSSW_12_5_X_2022-11-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40016/28877/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734658
  • DQMHistoTests: Total failures: 1009
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3733626
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

testing at p5

@emanueleusai
Copy link
Member

there are many differences in the DQM comparisons but they do not seem to be connected to this PR (and the PR in the master branch had 0 differences...)

@francescobrivio
Copy link
Contributor Author

there are many differences in the DQM comparisons but they do not seem to be connected to this PR (and the PR in the master branch had 0 differences...)

Hi Emanuele!
Differences in 11634.7 are known and being tracked in #39803.

@emanueleusai
Copy link
Member

+1

  • test at p5 successful

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

IB failures are unrelated.

@cmsbuild cmsbuild merged commit 3e63290 into cms-sw:CMSSW_12_5_X Nov 9, 2022
@francescobrivio francescobrivio deleted the alca-dqm_evtDisplay_12_5_X branch November 14, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants