Update EDM inputs to HLT-Validation tests [`8_0_X` only] #40030

missirol · 2022-11-09T10:25:09Z

PR description:

This PR is specific to the CMSSW_8_0_X release cycle.

Some of the HLT-Validation tests running in IBs started to fail due to the unavailability of EDM files used as input to these tests (see IB dashboard, and #40013).

This PR updates the path to these files, ~~to use copies kept in the TSG area on EOS.~~ which will now rely on the cms-bot cache (see discussion in #40013 and #40020, where the corresponding updates to cms-bot are also mentioned).

In addition, it disables the HLT-integration-tests part of the HLT-Validation tests for scram-archs in SLC6, which are incompatible with the most recent version of ConfDB-v2 (see #40013 (comment)).

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

cmsbuild · 2022-11-09T10:25:59Z

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/Configuration (hlt)
Utilities/ReleaseScripts (core)

@Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

missirol · 2022-11-09T10:27:45Z

please test

cmsbuild · 2022-11-09T16:54:32Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddf8e4/28917/summary.html
COMMIT: cd21891
CMSSW: CMSSW_8_0_X_2022-11-06-0000/slc6_amd64_gcc530
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40030/28917/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 1044635
DQMHistoTests: Total failures: 894
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1043633
DQMHistoTests: Total skipped: 108
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -14 KiB( 14 files compared)
Checked 62 log files, 13 edm output root files, 15 DQM output files

cmsbuild · 2022-11-23T17:38:00Z

Pull request #40030 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

missirol · 2022-11-23T17:40:19Z

please test

This will not fully fix the HLT-Validation tests in 8_0_X, because there seems to be an unrelated issue in accessing the menus from ConfDB (not sure why that is, locally it works):
https://cmssdt.cern.ch/SDT/jenkins-artifacts/HLT-Validation/CMSSW_8_0_X_2022-11-20-2300/slc6_amd64_gcc530/runIB.log

PS.

This will not fully fix the HLT-Validation tests in 8_0_X

Actually, this PR is not strictly needed (like the 5_3_X one), it is done more for consistency with the other ones; technically all input files of the HLT-Val tests in 8_0_X are accessible already.

cmsbuild · 2022-11-23T18:09:12Z

Pull request #40030 was updated. @Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please check and sign again.

missirol · 2022-11-23T18:15:57Z

please test

From #40013 (comment) ..

to use the bot cache (this 2nd option will not require signatures by Core-Sw)

.. sadly I have to retract this, as I would also change the input of one addon test (from RAW-RECO to RAW, which is the preferred tier for HLT). The file in question is not in the bot cache, but it will be once the PR is merged and tested in a IB (the file is currently at a T3).

cmsbuild · 2022-11-23T20:26:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddf8e4/29213/summary.html
COMMIT: 5db8986
CMSSW: CMSSW_8_0_X_2022-11-20-2300/slc6_amd64_gcc530
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40030/29213/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 1044635
DQMHistoTests: Total failures: 855
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1043672
DQMHistoTests: Total skipped: 108
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -14 KiB( 14 files compared)
Checked 62 log files, 13 edm output root files, 15 DQM output files

HLT-integration tests cannot run with SLC6 architectures, due to an incompatibility with the latest .jar files of ConfDB-v2. For further details, see cms-sw#40013 (comment)

cmsbuild · 2022-11-24T10:18:38Z

Pull request #40030 was updated. @Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please check and sign again.

missirol · 2022-11-24T10:25:11Z

please test

See #40013 (comment).

cmsbuild · 2022-11-24T11:38:53Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddf8e4/29234/summary.html
COMMIT: 557eea3
CMSSW: CMSSW_8_0_X_2022-11-20-2300/slc6_amd64_gcc530
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40030/29234/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 1044635
DQMHistoTests: Total failures: 860
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1043667
DQMHistoTests: Total skipped: 108
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -14 KiB( 14 files compared)
Checked 62 log files, 13 edm output root files, 15 DQM output files

missirol · 2022-11-24T12:16:06Z

+hlt

This PR fixes the HLT-Val tests currently failing in 8_0_X IBs (access EDM files from cms-bot cache + disable HLT-integration tests in SLC6).

The update of 1 input file of the addOnTests requires the signature of @cms-sw/core-l2 .

perrotta · 2022-11-24T12:43:44Z

+1

perrotta · 2022-11-24T12:47:12Z

Ah, ok: the @cms-sw/core-l2 is still missing.
I'll let the ORP signature anyhow: as soon as core will sign, this can get merged: if core has any remark, the orp signature alone will not be enough for merging

missirol · 2022-11-25T08:45:12Z

@smuzaffar , could you please check this PR, #40029 and #40028, and sign them for Core-Sw if you agree?

It would be good to test them in IBs over this weekend.

smuzaffar · 2022-11-25T09:28:27Z

+core
For Utilities/ReleaseScripts change, new input data is already available via ibeos cache.

cmsbuild · 2022-11-25T09:28:52Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will be automatically merged.

cmsbuild added this to the CMSSW_8_0_X milestone Nov 9, 2022

cmsbuild added core-pending hlt-pending orp-pending pending-signatures tests-pending labels Nov 9, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 9, 2022

cmsbuild added tests-approved and removed tests-started labels Nov 9, 2022

missirol mentioned this pull request Nov 22, 2022

HLT-Validation tests failing in IBs of CMSSW <= 12_1_X #40013

Closed

missirol force-pushed the fixHLTValTests_80X branch from cd21891 to 8766d10 Compare November 23, 2022 17:37

cmsbuild added tests-pending and removed core-pending tests-approved labels Nov 23, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 23, 2022

Update EDM input files of HLT-Validation tests

5db8986

missirol force-pushed the fixHLTValTests_80X branch from 8766d10 to 5db8986 Compare November 23, 2022 18:08

cmsbuild added core-pending tests-pending and removed tests-started labels Nov 23, 2022

cmsbuild removed the tests-pending label Nov 23, 2022

missirol mentioned this pull request Nov 23, 2022

Update EDM inputs to HLT-Validation tests [10_2_X only] #40028

Merged

cmsbuild added tests-approved and removed tests-started labels Nov 23, 2022

Skip HLT-integration tests in SLC6

557eea3

HLT-integration tests cannot run with SLC6 architectures, due to an incompatibility with the latest .jar files of ConfDB-v2. For further details, see cms-sw#40013 (comment)

cmsbuild added tests-pending and removed tests-approved labels Nov 24, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 24, 2022

cmsbuild added tests-approved and removed tests-started labels Nov 24, 2022

cmsbuild added hlt-approved and removed hlt-pending labels Nov 24, 2022

cmsbuild added orp-approved and removed orp-pending labels Nov 24, 2022

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Nov 25, 2022

cmsbuild merged commit 833a69f into cms-sw:CMSSW_8_0_X Nov 25, 2022

missirol deleted the fixHLTValTests_80X branch November 25, 2022 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update EDM inputs to HLT-Validation tests [`8_0_X` only] #40030

Update EDM inputs to HLT-Validation tests [`8_0_X` only] #40030

missirol commented Nov 9, 2022 •

edited

cmsbuild commented Nov 9, 2022

missirol commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

cmsbuild commented Nov 23, 2022

missirol commented Nov 23, 2022 •

edited

cmsbuild commented Nov 23, 2022

missirol commented Nov 23, 2022 •

edited

cmsbuild commented Nov 23, 2022

cmsbuild commented Nov 24, 2022

missirol commented Nov 24, 2022

cmsbuild commented Nov 24, 2022

missirol commented Nov 24, 2022

perrotta commented Nov 24, 2022

perrotta commented Nov 24, 2022

missirol commented Nov 25, 2022

smuzaffar commented Nov 25, 2022

cmsbuild commented Nov 25, 2022

Update EDM inputs to HLT-Validation tests [8_0_X only] #40030

Update EDM inputs to HLT-Validation tests [8_0_X only] #40030

Conversation

missirol commented Nov 9, 2022 • edited

PR description:

PR validation:

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

cmsbuild commented Nov 9, 2022

missirol commented Nov 9, 2022

cmsbuild commented Nov 9, 2022

Comparison Summary

cmsbuild commented Nov 23, 2022

missirol commented Nov 23, 2022 • edited

cmsbuild commented Nov 23, 2022

missirol commented Nov 23, 2022 • edited

cmsbuild commented Nov 23, 2022

Comparison Summary

cmsbuild commented Nov 24, 2022

missirol commented Nov 24, 2022

cmsbuild commented Nov 24, 2022

Comparison Summary

missirol commented Nov 24, 2022

perrotta commented Nov 24, 2022

perrotta commented Nov 24, 2022

missirol commented Nov 25, 2022

smuzaffar commented Nov 25, 2022

cmsbuild commented Nov 25, 2022

Update EDM inputs to HLT-Validation tests [`8_0_X` only] #40030

Update EDM inputs to HLT-Validation tests [`8_0_X` only] #40030

missirol commented Nov 9, 2022 •

edited

missirol commented Nov 23, 2022 •

edited

missirol commented Nov 23, 2022 •

edited