New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of clang fixes from CMSSW_7_1_CLANG_X branch #4004
Conversation
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X. Backport of clang fixes from CMSSW_7_1_CLANG_X branch It involves the following packages: CalibCalorimetry/EcalTPGTools @diguida, @ianna, @thspeer, @rcastello, @bendavid, @civanch, @ojeda, @cmsbuild, @ktf, @vciulli, @Dr15Jones, @mdhildreth, @rovere, @deguio, @slava77, @ggovi, @vadler, @Degano, @mulhearn, @apfeiffer1, @nclopezo, @danduggan, @thuer, @monttj, @StoyanStoynev can you please review it and eventually sign? Thanks. |
+1 |
@StoyanStoynev Can you please sign this off? I'll make sure I fix the bug after this one has been integrated (to avoid resetting all the signatures). |
+1 |
Backport of clang fixes from CMSSW_7_1_CLANG_X branch
Trivial bugfixes back ported from the CMSSW_7_1_CLANG_X branch. These are the ones which are "just fine" and unambiguous. There are still a few fixes in the above mentioned branch which will need backport but they will be done in a separate pull request since they non-trivially change implementation.