Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of clang fixes from CMSSW_7_1_CLANG_X branch #4004

Merged
merged 4 commits into from Jun 3, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented May 24, 2014

Trivial bugfixes back ported from the CMSSW_7_1_CLANG_X branch. These are the ones which are "just fine" and unambiguous. There are still a few fixes in the above mentioned branch which will need backport but they will be done in a separate pull request since they non-trivially change implementation.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Backport of clang fixes from CMSSW_7_1_CLANG_X branch

It involves the following packages:

CalibCalorimetry/EcalTPGTools
CondFormats/Serialization
DQM/HcalMonitorModule
DQMServices/Components
DataFormats/EcalDigi
DataFormats/PatCandidates
EventFilter/CSCRawToDigi
Geometry/CommonTopologies
JetMETCorrections/Type1MET
L1Trigger/GlobalTriggerAnalyzer
L1TriggerConfig/DTTPGConfigProducers
MuonAnalysis/MomentumScaleCalibration
PhysicsTools/FWLite
PhysicsTools/MVAComputer
PhysicsTools/MVATrainer
PhysicsTools/PatUtils
RecoParticleFlow/PFTracking
RecoPixelVertexing/PixelTriplets
RecoTracker/TkHitPairs
SimG4Core/GFlash
TauAnalysis/MCEmbeddingTools
TrackingTools/GeomPropagators
Validation/EventGenerator
Validation/RecoVertex

@diguida, @ianna, @thspeer, @rcastello, @bendavid, @civanch, @ojeda, @cmsbuild, @ktf, @vciulli, @Dr15Jones, @mdhildreth, @rovere, @deguio, @slava77, @ggovi, @vadler, @Degano, @mulhearn, @apfeiffer1, @nclopezo, @danduggan, @thuer, @monttj, @StoyanStoynev can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @GiacomoSguazzoni, @frmeier, @rovere, @argiro, @inugent, @nhanvtran, @gpetruc, @cerati, @mmusich, @lgray, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented May 26, 2014

+1

@ktf
Copy link
Contributor Author

ktf commented Jun 2, 2014

@StoyanStoynev Can you please sign this off? I'll make sure I fix the bug after this one has been integrated (to avoid resetting all the signatures).

@StoyanStoynev
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 3, 2014
Backport of clang fixes from CMSSW_7_1_CLANG_X branch
@davidlange6 davidlange6 merged commit e6b5529 into cms-sw:CMSSW_7_1_X Jun 3, 2014
ktf added a commit that referenced this pull request Jun 3, 2014
@ktf ktf mentioned this pull request Jun 3, 2014
ktf added a commit that referenced this pull request Jun 3, 2014
@ktf ktf deleted the more-clang-fixes branch June 16, 2014 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment