Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_5_X (1/N): HLT HIon V1.0 of 2022 [12_6_X] #40046

Merged
merged 1 commit into from Nov 11, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Nov 10, 2022

PR description:

Development of HLT menus for CMSSW_12_5_X.

This version of the HIon HLT menu corresponds to "HLT HIon V1.0" for the 2022 HIon (test) run.

This is the PR for the master branch, which will then be backported to 12_5_X (the latter is now the the release cycle used for HLT-menu development for Run 3; the development of HLT menus in 12_4_X has come to a close).

All development menus (e.g. GRun) and frozen menus are migrated to the latest ConfDB template for the 12_5_X release cycle. In particular, the frozen HLT menu ("HLT V1.5") of this release cycle is also updated to run in 12_5_X without extra customisations (this is purely a technical change, no physics changes expected).

This PR includes the integration of the following JIRA tickets.

  • CMSHLT-2532: [HIon] updated HIDQMEventDisplay stream (added HIMinBias trigger with smartPS of 2000)
  • CMSHLT-2536: [HIon] switched to rawDataRepacker in EventContent of HIDQMEventDisplay
  • CMSHLT-2541: [EXO] set PS=0 for HLT_HT200_L1SingleLLPJet_DisplacedDijet30_Inclusive1PtrkShortSig5_v
  • CMSHLT-2542: [TSG] set PS=1 for HLT_EphemeralZeroBias_v
  • CMSHLT-2546: [BPH] set PS=20 for HLT_DoubleMu4_3_Jpsi_v
  • CMSHLT-2547: [TSG,TRK] increased PSs of HLT_HT300_Beamspot_v trigger
  • CMSHLT-2548: [EXO,MUO] set PS=1 for HLT_Mu50_L1SingleMuShower_v trigger
  • CMSHLT-2550: [TSG] changed default PS column to "2p0E34"
  • CMSHLT-2553: [BPH] added dielectron-parking triggers with trkHits10 cut
  • CMSHLT-2556: [HIon] added HLT_HIRandom_v to HITestRaw and HITestRawPrime PDs
  • CMSHLT-2559: [TRK] updated EventContent of HIDQMOnlineBeamspot stream
  • CMSHLT-2560: [HIon] added FED 1022 to rawPrimeDataRepacker
  • CMSHLT-2563: [HIon] fixed offset of HIMinBias prescaler and smartPS of HIZeroBias in HIExpressPhysics PD
  • CMSHLT-2565: [LUM,HIon] added AlCaPCC triggers and streams to HIon menu (combined table unchanged)
  • CMSHLT-2566: [HIon] added HIUPC triggers to HITestRawPrime PD

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_12_5_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40046/33002

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c09f0e/28963/summary.html
COMMIT: 29cd161
CMSSW: CMSSW_12_6_X_2022-11-10-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40046/28963/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416438
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 36
  • DQMHistoTests: Total successes: 3416370
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 137.209 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 19.601 KiB HLT/Filters
  • DQMHistoSizes: changed ( 7.3,... ): 0.001 KiB HLT/Filters
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19864
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented Nov 10, 2022

+hlt

  • differences in the outputs of PR tests are in line with the update of the HLT GRun menu
  • a few additional differences in non-Run3 wfs are due to the update in the name of the 'fake' HLT menus

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@missirol missirol deleted the HLTdevelopment125X_for126X branch November 15, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants