[12_4_X] [TsosGaussianStateConversions] proposal fix for Gsf Tracking segmentation fault when no states are passing selection criteria

[swagata87]

PR description:

Backport of #40017, to address #39987.

PR validation:

runTheMatrix.py -l 12434.0 ran fine.

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_12_4_X.

It involves the following packages:

• TrackingTools/GsfTracking (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @bellan, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @ebrondol, @lecriste, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from [TsosGaussianStateConversions] proposal fix for Gsf Tracking segmentation fault when no states are passing selection criteria  #40017

[perrotta]

please test

[perrotta]

backport of #40017

[perrotta]

urgent

[perrotta]

ping bot

[perrotta]

@smuzaffar apparently tests are not able to start here: can anything be done for it?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-282ac9/28999/summary.html
COMMIT: aec3325
CMSSW: CMSSW_12_4_X_2022-11-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40063/28999/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3720277
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3720253
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[rappoccio]

@cms-sw/reconstruction-l2 can you sign this today? We'd like to cut the next 12_4 ASAP.

[francescobrivio]

We'd like to cut the next 12_4 ASAP.

Please Sal see the discussion in #39987 (comment) befor cutting a new 12_4_X

[slava77]

wouldn't a backport of #40084 be needed as well

[swagata87]

wouldn't a backport of #40084 be needed as well

yes it is here now: #40085

[mmusich]

yes it is here now: #40085

Given the long latencies of reco signatures lately, isn't perhaps more straightforward to cherry pick that commit directly here?

[perrotta]

@mandrenguyen @clacaputo could you please review, and possibly sign for @cms-sw/reconstruction-l2, at your earliest convenience this and the other PRs which were marked as "urgent" for 12_4_X? Thank you!

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1