Phase2TrackerDigitizer: Activating Bias Rail Inefficiency

[suchandradutta]

PR description:

Activating the bias rails inefficiency for PS-p modules by default as it is the intrinsic to the sensor itself. SimHits are discarded (not considered for Digitization) when the trajectory is entirely inside the bias rail region. At the moment we consider also those SimHits for which the trajectory is partly outside (optimistic scenario with 'AND' condition for Entry/Exit points of SimHits) the bias rail region.

Note : the code was already integrated before we are now switching it on through a configuration parameter.

We expect to find less digis in PSP modules due to this inefficiency

At the moment we are estimating the effect of this inefficiency in L1 tracking and it is not fully optimized. We might move to a more pessimistic scenario when we shall not consider the SimHits where the the trajectory is event partly inside the bias rail region ( 'OR' condition for Entry/Exit points of SimHits)

PR validation and some performance updates

• Bi-weekly modelling, simulation and performance Meeting 11/11/2022

• Bi-weekly modelling, simulation and performance Meeting 11/11/2022

• Bi-weekly modelling, simulation and performance Meeting 27/05/2022

Note : all the above validation plots are presented with the pessimistic 'OR' option

@emiglior

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40069/33053

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for master.

It involves the following packages:

• SimTracker/SiPhase2Digitizer (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@beaucero, @VourMa, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @trtomei, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc2b6b/29040/summary.html
COMMIT: 5dde5a0
CMSSW: CMSSW_12_6_X_2022-11-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40069/29040/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11945 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417074
• DQMHistoTests: Total failures: 6648
• DQMHistoTests: Total nulls: 84
• DQMHistoTests: Total successes: 3410320
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: found differences in 2 / 46 workflows

[mmusich]

please test

• spurious failure

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc2b6b/29061/summary.html
COMMIT: 5dde5a0
CMSSW: CMSSW_12_6_X_2022-11-16-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40069/29061/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11949 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417074
• DQMHistoTests: Total failures: 6654
• DQMHistoTests: Total nulls: 84
• DQMHistoTests: Total successes: 3410314
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: found differences in 2 / 46 workflows

[civanch]

@suchandradutta , I agree with proposed implementation but am not sure if it is a correct approach to add any filter if the geometry the new tracker is not fully finalized. Usually such type of filter or mask are added to very final variant of simulation.

[emiglior]

Hi @civanch, as mentioned in the PR description, this inefficiency is kind of unavoidable.
For the moment, we would prefer to keep the activation of the mask as an option to make the comparison with past results easier and to allow the development of mitigation strategies.

[civanch]

+1

[srimanob]

+Upgrade

Maybe OR and AND should be control via configuration in case of the need of comparison in future.

Changes are seen in all Phase-2 workflows as expected since the PR effects only Phase-2. Note to @cms-sw/pdmv-l2 on the validation when the release with this PR comes out.

[mmusich]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40069/33092

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #40069 was updated. @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please check and sign again.

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc2b6b/29122/summary.html
COMMIT: 024533d
CMSSW: CMSSW_12_6_X_2022-11-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40069/29122/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11970 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417167
• DQMHistoTests: Total failures: 6650
• DQMHistoTests: Total nulls: 84
• DQMHistoTests: Total successes: 3410411
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: found differences in 2 / 46 workflows

[mmusich]

please test

• failure is spurious

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc2b6b/29130/summary.html
COMMIT: 024533d
CMSSW: CMSSW_12_6_X_2022-11-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40069/29130/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11974 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417167
• DQMHistoTests: Total failures: 6653
• DQMHistoTests: Total nulls: 84
• DQMHistoTests: Total successes: 3410408
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: found differences in 2 / 46 workflows

[civanch]

+1

[srimanob]

+Upgrade

Re-sign

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1