Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTID integrity error plots for ECAL DQM [Master] #40072

Merged
merged 1 commit into from Nov 28, 2022

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Nov 15, 2022

PR description:

This PR adds the following plots to monitor the TTID integrity errors in ECAL DQM:

  1. Total TTID errors per FED for the whole run.
  2. TTID errors per FED per lumisection.
  3. TTID errors for each supermodule normalized by the no.of events processed.

PR validation:

This was validated by running the online DQM workflow and testing the plots on a test DQM GUI.
Also validated by running the runtheMatrix workflow 136.874

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the master PR.
Backports are made to 12_5_X #40073 and 12_4_X #40074

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40072/33055

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abhih1 (Abhirami Harilal) for master.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)
  • DQM/EcalMonitorTasks (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

type ecal

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0d0c9/29024/summary.html
COMMIT: aa8675e
CMSSW: CMSSW_12_6_X_2022-11-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40072/29024/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417074
  • DQMHistoTests: Total failures: 1787
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3415265
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 767.4279999999999 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 18.477 KiB EcalBarrel/EBIntegrityTask
  • DQMHistoSizes: changed ( 1000.0,... ): 7.848 KiB EcalEndcap/EEIntegrityTask
  • DQMHistoSizes: changed ( 20834.0,... ): 0.406 KiB EcalBarrel/EBIntegrityTask
  • DQMHistoSizes: changed ( 20834.0,... ): 0.266 KiB EcalEndcap/EEIntegrityTask
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • DQM comparison differences in E[E,B]IntegrityClient and E[E,B]SummaryClient as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@syuvivida
Copy link
Contributor

Hello,
sorry we would like to check if this PR went into any later 12_6_X release. This PR is merged to the master branch on November 28 but somehow it is not yet in 12_6_2. Thanks!!

@perrotta
Copy link
Contributor

perrotta commented Feb 1, 2023

Hello, sorry we would like to check if this PR went into any later 12_6_X release. This PR is merged to the master branch on November 28 but somehow it is not yet in 12_6_2. Thanks!!

Yes, of course. Master branch on Nov 28 (well, since Nov 24 in fact) was already 12_3_X, and therefore this PR is merged there. If you want it in 12_6_X you must prepare a backport PR to that cycle.

@syuvivida
Copy link
Contributor

@perrotta ok, we will contact the authors of this PR to make a backport to 12_6_X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants