Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTID integrity error plots for ECAL DQM [12_5_X] #40073

Merged
merged 1 commit into from Nov 29, 2022

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Nov 15, 2022

PR description:

This PR adds the following plots to monitor the TTID integrity errors in ECAL DQM:

  1. Total TTID errors per FED for the whole run.
  2. TTID errors per FED per lumisection.
  3. TTID errors for each supermodule normalized by the no.of events processed.

PR validation:

This was validated by running the online DQM workflow and testing the plots on a test DQM GUI.
Also validated by running the runtheMatrix workflow 136.874

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

The master PR is #40072.
This is backported to have the changes available in 12_5_X which is next in production

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2022

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_5_X.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)
  • DQM/EcalMonitorTasks (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@abhih1 abhih1 changed the title Add TTID error plots for ECAL DQM [12_5_X] Add TTID integrity error plots for ECAL DQM [12_5_X] Nov 15, 2022
@emanueleusai
Copy link
Member

type ecal

@cmsbuild cmsbuild added the ecal label Nov 16, 2022
@emanueleusai
Copy link
Member

backport of #40072

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc2850/29025/summary.html
COMMIT: e0a5153
CMSSW: CMSSW_12_5_X_2022-11-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40073/29025/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734871
  • DQMHistoTests: Total failures: 1797
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3733051
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 768.776 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 18.477 KiB EcalBarrel/EBIntegrityTask
  • DQMHistoSizes: changed ( 1000.0,... ): 7.848 KiB EcalEndcap/EEIntegrityTask
  • DQMHistoSizes: changed ( 23234.0,... ): 0.406 KiB EcalBarrel/EBIntegrityTask
  • DQMHistoSizes: changed ( 23234.0,... ): 0.266 KiB EcalEndcap/EEIntegrityTask
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • DQM comparison differences in E[E,B]IntegrityClient and E[E,B]SummaryClient as expected.
  • tested and deployed at P5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Merging just to have the offline release aligned with what deployed in the online DQM release at P5 at the end of the data taking: there will be no real usage for this PR in a possible future release in this cycle.

@cmsbuild cmsbuild merged commit 90286b7 into cms-sw:CMSSW_12_5_X Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants