Improve unprotected areas of GSF code to avoid segfault

[swagata87]

PR description:

This PR fixes a crash in prompt reco in run number 361971 as reported in #39987 (comment).

In Run3, by now, there were at least 3 instances of crashes in prompt reco due to Gsf, to the best of my knowledge. Apparently the error-messages looks similar, but they needed different fixes. To fix this particular crash, we need some extra protection against edge-cases, in GsfTrajectorySmoother.

PR validation:

Checked that the reported crash in run 361971 gets solved.
runTheMatrix.py -l 12434.0 ran fine.

I intend to backport it to 12_4_X and 12_5_X soon.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40084/33066

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

• TrackingTools/GsfTracking (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @bellan, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @ebrondol, @lecriste, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[swagata87]

@cmsbuild please test

[slava77]

type tracking,egamma

[perrotta]

Thank you @swagata87 : could you please prepare also a backport for 12_5_X, so that it does not get fogotten?

[francescobrivio]

urgent

• its backport should be included in the upcoming 12_4_X to avoid crashes in tier0 prompt reco

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-523e9b/29045/summary.html
COMMIT: 6c540c0
CMSSW: CMSSW_12_6_X_2022-11-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40084/29045/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417074
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3417049
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• It is just some additional protection added to the code, and I don't expect @cms-sw/reconstruction-l2 can have anything against it preventing their signature: let me just merge it in master, so that tomorrow we can do the same also for the backports
• @mandrenguyen @clacaputo please add either your signature and/or your comments here, and in particular in the two backports to 12_4 and 12_5 at your earliest convenience

[perrotta]

merge

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.