Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against particles with zero weight and pt being given to njettiness [12_5_X] #40092

Conversation

laurenhay
Copy link
Contributor

PR description:

As discussed in issue #40032 , BoostedDoubleSVProducer caused an abort signal in a reco job.
We found that there were unrealistic kinematic values in fjParticles being input to njettiness and are protecting against it by requiring a nonzero weight and pt > epsilon.

PR validation:

Verified that this fix solves the issues in CMSSW_12_4_10_patch3 and ran usual code check and that basic runTheMatrix workflows run in 12_5_2_patch1

@rappoccio

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Original PR: #40081
First bp: #40088
Backport is needed so that future reco jobs run without being stopped by this issue

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 16, 2022

A new Pull Request was created by @laurenhay (Lauren Hay) for CMSSW_12_5_X.

It involves the following packages:

  • RecoBTag/SecondaryVertex (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @JyothsnaKomaragiri, @AnnikaStein, @missirol, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

Backport of #40081

@rappoccio
Copy link
Contributor

urgent

@rappoccio
Copy link
Contributor

please test

@perrotta perrotta changed the title Protect against particles with zero weight and pt being given to njettiness Protect against particles with zero weight and pt being given to njettiness [12_5_X] Nov 17, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bee59e/29087/summary.html
COMMIT: 59a4362
CMSSW: CMSSW_12_5_X_2022-11-17-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40092/29087/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734871
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3734847
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Backport of PR that fixes prompt reco crash.

@cmsbuild cmsbuild merged commit e660fdf into cms-sw:CMSSW_12_5_X Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants