Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx330 Transfer most of the HGCal TB related geometry file to the new branch Geometry/HGCalTBCommonData #40122

Merged
merged 1 commit into from Nov 25, 2022

Conversation

bsunanda
Copy link
Contributor

PR description:

Transfer most of the HGCal test-beam related geometry files to anew project area Geometry/HGCalTBCommonData. Once this PR is merged and this project area is declared as a part of CMSSW, the corresponding files in Geometry/HGCalCommonData will be deleted

PR validation:

A thorough test will be done once the corresponding files in SimG4CMS are updated

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40122/33115

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/HGCalTBCommonData (****)

The following packages do not have a category, yet:

Geometry/HGCalTBCommonData
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@bsunanda
Copy link
Contributor Author

@smuzaffar Could you please add this package in the list

@smuzaffar
Copy link
Contributor

@bsunanda , done in #40122

@cmsbuild
Copy link
Contributor

Pull request #40122 was updated. @civanch, @Dr15Jones, @makortel, @ianna, @mdhildreth, @bsunanda can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60fa3/29226/summary.html
COMMIT: abb4928
CMSSW: CMSSW_12_6_X_2022-11-23-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40122/29226/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417239
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417211
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

+geometry

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed this from the CMSSW_12_6_X milestone Nov 24, 2022
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Nov 24, 2022
@perrotta
Copy link
Contributor

+1

  • @bsunanda please proceed with the deletion of the duplicated files, then (and the needed redirections, I imagine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants