Remove deprecated `exists` API in favor of `fillDescriptions` in `SiPixelQualityESProducer` #40135

ferencek · 2022-11-22T23:19:22Z

PR description:

This PR addresses issue #40077

PR validation:

Code compiles and cmsDriver from the original JIRA runs successfully.

Backports:

No backports are needed.

cmsbuild · 2022-11-22T23:27:34Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40135/33127

This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40135/33127/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40135/33127/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-11-22T23:39:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40135/33128

This PR adds an extra 12KB to repository

cmsbuild · 2022-11-22T23:39:45Z

A new Pull Request was created by @ferencek (Dinko F.) for master.

It involves the following packages:

CalibTracker/SiPixelESProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @mroguljic, @dkotlins, @ferencek, @mmusich, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mmusich · 2022-11-22T23:59:11Z

please test

mmusich · 2022-11-23T00:00:06Z

CalibTracker/SiPixelESProducers/plugins/SiPixelQualityESProducer.cc

+    }
+    desc.addVPSet("ListOfRecordToMerge", desc_ps, default_ps);
+  }
+  descriptions.add("siPixelQualityESProducer", desc);


This could be addWithDefaultLabel

Thanks for the comment. Right, I didn't realize that addWithDefaultLabel produces a cfi file with the name that matches the C++ class name but with the first character in lower case. Since the test are already done, I would avoid re-triggering all the tests just for this cosmetic change.

hi @ferencek given that the whole PR is somewhat "cosmetic" and there is no urgent need for it to get merged, I think it's fine to retrigger tests, it's better to have this done now then to remember it and do it later...

cmsbuild · 2022-11-23T05:58:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca993e/29199/summary.html
COMMIT: 9ecd960
CMSSW: CMSSW_12_6_X_2022-11-22-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40135/29199/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3417239
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3417208
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

mmusich

In case there's a follow-up to https://github.com/cms-sw/cmssw/pull/40135/files#r1030742953, I have two more "cosmetic" comments.

mmusich · 2022-11-23T14:55:19Z

CalibTracker/SiPixelESProducers/plugins/SiPixelQualityESProducer.cc

@@ -141,4 +142,32 @@ void SiPixelQualityESProducer::setIntervalFor(const edm::eventsetup::EventSetupR
  oValidity = infinity;
 }

+void SiPixelQualityESProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
+  // siPixelQualityESProducer


What's the purpose of this commented line?

This was a literal copy-paste from the edmPythonConfigToCppValidation executable described in this TWiki. Will remove it.

mmusich · 2022-11-23T14:56:10Z

CalibTracker/SiPixelESProducers/plugins/SiPixelQualityESProducer.cc

+      temp.addParameter<std::string>("record", "SiPixelDetVOffRcd");
+      temp.addParameter<std::string>("tag", "");
+      default_ps.push_back(temp);
+    }


The whole section above could be replaced by a loop.

This was also a literal copy-paste from the edmPythonConfigToCppValidation executable with some changes in variable names to make them a bit more descriptive. I am not actually sure what you want to put in the loop. If you are referring to the two default_ps.push_back(temp); calls, the record parameter differs in the two instances and introducing some if statements would seem less elegant that this implementation proposed by edmPythonConfigToCppValidation. This I leave as is for now unless I misunderstood what you meant.

calls, the record parameter differs in the two instances and introducing some if

No need of an if, you can just declare an array with record names and loop over it with range-based loop while doing the push_back

To be honest, I find the readability of the code dumped by edmPythonConfigToCppValidation better than having it in a loop form because it resembles more the layout of the final cfi file. Unless there is some performance issue with the current implementation, which I doubt, I leave it as is :) If it bothers you that much, the branch is under the CMSTrackerDPG organization ;)

I guess we have different taste in readability. Anyway It does not bother me at all, it was said upfront it's "cosmetics".

cmsbuild · 2022-11-23T19:37:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40135/33130

This PR adds an extra 12KB to repository

cmsbuild · 2022-11-23T19:37:44Z

Pull request #40135 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

sroychow · 2022-11-25T11:11:50Z

please test

cmsbuild · 2022-11-26T00:39:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca993e/29256/summary.html
COMMIT: 357f32c
CMSSW: CMSSW_12_6_X_2022-11-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40135/29256/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3417239
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3417214
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

tvami · 2022-11-26T19:08:10Z

+alca

tests pass, diffs in MsgLogger only

cmsbuild · 2022-11-26T19:08:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-11-28T09:24:36Z

+1

cmsbuild added this to the CMSSW_12_6_X milestone Nov 22, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Nov 22, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 22, 2022

ferencek force-pushed the SiPixelQualityESProducer_fillDescriptions-12_6_X branch from 5445d84 to 9ecd960 Compare November 22, 2022 23:31

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 22, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 22, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 22, 2022

mmusich reviewed Nov 23, 2022

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Nov 23, 2022

mmusich reviewed Nov 23, 2022

View reviewed changes

remove deprecated exists API in favor of fillDescriptions

357f32c

ferencek force-pushed the SiPixelQualityESProducer_fillDescriptions-12_6_X branch from 9ecd960 to 357f32c Compare November 23, 2022 19:28

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Nov 23, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 23, 2022

cmsbuild modified the milestones: CMSSW_12_6_X, CMSSW_13_0_X Nov 24, 2022

cmsbuild added tests-started and removed tests-pending labels Nov 25, 2022

cmsbuild added tests-approved and removed tests-started labels Nov 26, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Nov 26, 2022

cmsbuild added orp-approved and removed orp-pending labels Nov 28, 2022

cmsbuild merged commit 33df828 into cms-sw:master Nov 28, 2022

mmusich mentioned this pull request Nov 28, 2022

Remove deprecated exists API in favor of fillDescriptions in CalibTracker/SiPixelESProducers/plugins/SiPixelQualityESProducer.cc #40077

Closed

ferencek deleted the SiPixelQualityESProducer_fillDescriptions-12_6_X branch November 28, 2022 11:07

This was referenced Nov 28, 2022

Update LLVM to version 14.0.6 cms-sw/cmsdist#8201

Merged

Updated root to tip of branch v6-26-00-patches cms-sw/cmsdist#8204

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated `exists` API in favor of `fillDescriptions` in `SiPixelQualityESProducer` #40135

Remove deprecated `exists` API in favor of `fillDescriptions` in `SiPixelQualityESProducer` #40135

ferencek commented Nov 22, 2022

cmsbuild commented Nov 22, 2022

cmsbuild commented Nov 22, 2022

cmsbuild commented Nov 22, 2022

mmusich commented Nov 22, 2022

mmusich Nov 23, 2022

ferencek Nov 23, 2022

tvami Nov 23, 2022

cmsbuild commented Nov 23, 2022

mmusich left a comment

mmusich Nov 23, 2022

ferencek Nov 23, 2022

mmusich Nov 23, 2022

ferencek Nov 23, 2022

mmusich Nov 23, 2022

mmusich Nov 23, 2022

ferencek Nov 23, 2022

mmusich Nov 23, 2022

cmsbuild commented Nov 23, 2022

cmsbuild commented Nov 23, 2022

sroychow commented Nov 25, 2022

cmsbuild commented Nov 26, 2022

tvami commented Nov 26, 2022

cmsbuild commented Nov 26, 2022

perrotta commented Nov 28, 2022

Remove deprecated exists API in favor of fillDescriptions in SiPixelQualityESProducer #40135

Remove deprecated exists API in favor of fillDescriptions in SiPixelQualityESProducer #40135

Conversation

ferencek commented Nov 22, 2022

PR description:

PR validation:

Backports:

cmsbuild commented Nov 22, 2022

cmsbuild commented Nov 22, 2022

cmsbuild commented Nov 22, 2022

mmusich commented Nov 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Nov 23, 2022

Comparison Summary

mmusich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Nov 23, 2022

cmsbuild commented Nov 23, 2022

sroychow commented Nov 25, 2022

cmsbuild commented Nov 26, 2022

Comparison Summary

tvami commented Nov 26, 2022

cmsbuild commented Nov 26, 2022

perrotta commented Nov 28, 2022

Remove deprecated `exists` API in favor of `fillDescriptions` in `SiPixelQualityESProducer` #40135

Remove deprecated `exists` API in favor of `fillDescriptions` in `SiPixelQualityESProducer` #40135