Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning message about PixelCPEFast in TkTransientTrackingRecHitBuilderESProducer #40170

Merged
merged 2 commits into from Nov 30, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 29, 2022

PR description:

This PR is a follow-up to #40003, which added the TransientTrackingRechitBuilder flavour for PixelCPEFast.
In that PR a new warning was emitted from TkTransientTrackingRecHitBuilderESProducer in order to warn the user that track angles will not be used, but since that was implemented in the constructor or the class, the message ended up being emitted every time the TransientTrackingRecHitBuilder_cfi was loaded, leading to the misleading message that PixelCPEFast was used in the track fit, even when in fact it was not (logs from recent IB relvals show that the message is present in each one of them, see e.g. wf 1.0 or wf 250408.0 ).
This PR fixes the problem by moving the LogWarning from the class constructor to the produce method, such that it is emitted only if the ES products are actually consumed by the downstream modules.
I profit of this PR (in commit 6bcc614) to automatically supply a service needed in case of the PixelCPEFast choice in tracker alignment common refitting sequence.

PR validation:

Tested with this branch that the spurious messages in relvals are removed.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will need to be backported to the 12.6.X cycle.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2022

type tracking, bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40170/33185

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/CommonAlignment (alca)
  • RecoTracker/TransientTrackingRecHit (reconstruction)

@malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @VourMa, @adewit, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @missirol, @rovere, @tlampen, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9947e7/29320/summary.html
COMMIT: 6bcc614
CMSSW: CMSSW_13_0_X_2022-11-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40170/29320/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421128
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Nov 29, 2022

+alca

  • tests pass, diffs in MsgLogger, as expected, OTOH I dont know how to check what was the log before and after the change

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2022

urgent

  • because the backport is urgent

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2022

OTOH I dont know how to check what was the log before and after the change

e.g. IBs vs This PR

@mandrenguyen
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Nov 29, 2022

OTOH I dont know how to check what was the log before and after the change

e.g. IBs vs This PR

Thanks Marco!

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bf75702 into cms-sw:master Nov 30, 2022
@mmusich mmusich deleted the CPEFastTrackRefitter_follow-up_13_0_X branch November 30, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants