Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TkAl] Fix EoP Validation plotting macros #40182

Merged
merged 2 commits into from Dec 15, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 29, 2022

PR description:

In response to #40080 (comment).

  • refurbished momentumElectronBiasValidation.C macro;
  • applied code-format to momentumBiasValidation.C macro, and modified it in order to compile it together with the electron one;
  • added dedicated EoP validation plotting unit tests;

PR validation:

Relies on the unit tests created here, run successfully

scram b runtests_testEoPPlotting

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40182/33196

  • This PR adds an extra 32KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2022

please test

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2022

type trk, bug-fix

@tvami
Copy link
Contributor

tvami commented Nov 29, 2022

seems like the unit test timed out?

/bin/sh: line 1: 28007 Aborted                 timeout 3600 sh -c 'testEoPPlotting '

---> test testEoPPlotting had ERRORS
TestTime:5
^^^^ End Test testEoPPlotting ^^^^

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-977702/29340/unitTests/src/Alignment/OfflineValidation/test/testEoPPlotting/testing.log

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2022

seems like the unit test timed out?

I don't think so

TestTime:5

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-977702/29340/summary.html
COMMIT: 43ece4e
CMSSW: CMSSW_13_0_X_2022-11-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40182/29340/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testEoPPlotting had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421131
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40182/33226

  • This PR adds an extra 36KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

   * avoid overriding variable from the two eop macros
   * do not run pion plotting in the same test as electron one
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40182/33394

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40182 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 14, 2022

Should we squash the commits and test one more time and merge this?

@tvami done. Feel free to test

@tvami
Copy link
Contributor

tvami commented Dec 14, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-977702/29622/summary.html
COMMIT: 7e15bdf
CMSSW: CMSSW_13_0_X_2022-12-14-1700/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40182/29622/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 25 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557521
  • DQMHistoTests: Total failures: 1188
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3556311
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Dec 14, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants