New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TkAl] Fix EoP Validation plotting macros #40182
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40182/33196
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
type trk, bug-fix |
seems like the unit test timed out?
|
I don't think so
|
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test testEoPPlotting had ERRORS Comparison SummarySummary:
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40182/33226
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
5c6c8cd
to
941d07f
Compare
* avoid overriding variable from the two eop macros * do not run pion plotting in the same test as electron one
d62dc9a
to
7e15bdf
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40182/33394
|
Pull request #40182 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again. |
@tvami done. Feel free to test |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-977702/29622/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In response to #40080 (comment).
momentumElectronBiasValidation.C
macro;momentumBiasValidation.C
macro, and modified it in order to compile it together with the electron one;PR validation:
Relies on the unit tests created here, run successfully
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A