Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FakeHistos V1 : plugins part #40225

Merged
merged 3 commits into from Dec 8, 2022
Merged

FakeHistos V1 : plugins part #40225

merged 3 commits into from Dec 8, 2022

Conversation

archiron
Copy link
Contributor

@archiron archiron commented Dec 2, 2022

PR description:

PR description:
Following the last PR (38569, 39404, 39504) we have updated the Fake level after the RECO one.
The monitoring of the "extended" region (2.5<|eta|<3) has been added and the same histos as in RECO level are removed .

Modifications are made on the following files :
Validation/RecoEgamma/plugins/ElectronMcFakeValidator.cc
Validation/RecoEgamma/plugins/ElectronMcFakeValidator.h
Validation/RecoEgamma/plugins/ElectronMcFakePostValidator.cc
Validation/RecoEgamma/python/ElectronMcFakeValidator_gedGsfElectrons_cfi.py

PR validation:

scram build code-checks → OK
scram build code-format → OK

compilation is OK, basics tests (scram b runtests or local tests) are OK too.

runTheMatrix.py -l limited -i all --ibeos tests are almost fine :
48 47 45 32 18 4 1 1 1 1 1 tests passed, 0 0 1 0 0 0 0 0 0 0 0 failed
pbm is for 11834.0 with exit code : 35072 (see added file)
with :
Error in determining L1T prescales for HLT path: 'MC_Run3_PFScoutingPixelTracking_v17' with complex L1T seed: 'L1GlobalDecision' using L1TGlobalUtil:
and lot of :
Rivet.Analysis.HiggsTemplateCrossSections: WARN Unkown Higgs production mechanism. Cannot classify event. Classification for all events will most likely fail.

runall-report-step123-.log

@beaudett

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40225/33266

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

A new Pull Request was created by @archiron (Chiron) for master.

It involves the following packages:

  • Validation/RecoEgamma (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04a1c5/29480/summary.html
COMMIT: 9a57ddb
CMSSW: CMSSW_13_0_X_2022-12-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40225/29480/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3420721
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3420694
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 88.18999999999997 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 3.719 KiB EgammaV/ElectronMcFakeValidator
  • DQMHistoSizes: changed ( 20834.0,... ): 1.062 KiB EgammaV/ElectronMcFakeValidator
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • changes in egammaV DQM plots as expected

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fb299cb into cms-sw:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants