New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FakeHistos V1 : plugins part #40225
FakeHistos V1 : plugins part #40225
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40225/33266
|
A new Pull Request was created by @archiron (Chiron) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04a1c5/29480/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR description:
Following the last PR (38569, 39404, 39504) we have updated the Fake level after the RECO one.
The monitoring of the "extended" region (2.5<|eta|<3) has been added and the same histos as in RECO level are removed .
Modifications are made on the following files :
Validation/RecoEgamma/plugins/ElectronMcFakeValidator.cc
Validation/RecoEgamma/plugins/ElectronMcFakeValidator.h
Validation/RecoEgamma/plugins/ElectronMcFakePostValidator.cc
Validation/RecoEgamma/python/ElectronMcFakeValidator_gedGsfElectrons_cfi.py
PR validation:
scram build code-checks → OK
scram build code-format → OK
compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are almost fine :
48 47 45 32 18 4 1 1 1 1 1 tests passed, 0 0 1 0 0 0 0 0 0 0 0 failed
pbm is for 11834.0 with exit code : 35072 (see added file)
with :
Error in determining L1T prescales for HLT path: 'MC_Run3_PFScoutingPixelTracking_v17' with complex L1T seed: 'L1GlobalDecision' using L1TGlobalUtil:
and lot of :
Rivet.Analysis.HiggsTemplateCrossSections: WARN Unkown Higgs production mechanism. Cannot classify event. Classification for all events will most likely fail.
runall-report-step123-.log
@beaudett