Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JMENanoAOD] Setup DQM and increase precision of PileUp ID & QGL input variables #40232

Merged

Conversation

nurfikri89
Copy link
Contributor

@nurfikri89 nurfikri89 commented Dec 3, 2022

This PR updates the JMENano workflow to make the following changes:

  • Setup the DQM for JMENano. The DQM step name is nanojmeDQM.
  • Increase the precision for the PileUp ID and Quark-Gluon Likelihood input variables.
  • Add AK4 jet ParticleNet gluon raw score.
  • Bugfix related to JetID configurations in JMENano.

PR validation:

  • passes the JMENano workflows: runTheMatrix.py -i all --ibeos -l 10224.15,11024.15,25202.15,11634.15

With this PR, the event size is 6.58 kb/event. The test was done with 10K events from a TTTo2J1L1Nu Run3Winter22MiniAOD file. Here is the cputime:
cputime

The full content and size details can be found in the JMENano twiki: size / content

if this PR is a backport please specify the original PR and why you need to backport that PR:

Once merged, this PR needs to be backported to 12_6_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40232/33281

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2022

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

  • DQMOffline/Configuration (dqm)
  • PhysicsTools/NanoAOD (xpog)

@swertz, @vlimant, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@gpetruc, @threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor

swertz commented Dec 5, 2022

please test workflow 10224.15,11024.15,25202.15,11634.15

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7e6f2/29463/summary.html
COMMIT: 4aa7802
CMSSW: CMSSW_13_0_X_2022-12-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40232/29463/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 54 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3870604
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3870580
  • DQMHistoTests: Total skipped: 24
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 226 log files, 178 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@swertz
Copy link
Contributor

swertz commented Dec 6, 2022

+1

Can you please prepare the backport to 12_6_X?

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 85ad022 into cms-sw:master Dec 6, 2022
cmsbuild added a commit that referenced this pull request Dec 8, 2022
…11_ForPR

[JMENanoAOD] Backport of #40232 (Setup DQM and increase precision of PileUp ID & QGL input variables) to 12_6_X
@nurfikri89 nurfikri89 deleted the from130X_202212011100_JMENanoV11_ForPR branch October 29, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants