Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Geant4 user actions #40252

Merged
merged 2 commits into from Dec 7, 2022
Merged

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Dec 6, 2022

PR description:

Geant4 StackingAction is updated to fix rare issues happens in the case of active G4GammaGeneralProcess. This happens due to loss of numerical precision in selection of a concrete gamma process in PostStepDoIt action. This should fully resolve #40090

In SteppingAction the limit on number of warnings is reduced from 5 to 2. There is no sense for repeated warnings.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: May be backported to 12_6

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40252/33303

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2022

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

  • SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Dec 6, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cbd6f/29490/summary.html
COMMIT: a01cb49
CMSSW: CMSSW_13_0_X_2022-12-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40252/29490/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421337
  • DQMHistoTests: Total failures: 149
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421166
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor Author

civanch commented Dec 7, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SegFault in OscarMTProducer when running unoptimized code
3 participants