ECAL Timing Reco: CrossCorrelation algorithm update

[nminafra]

This PR introduces:

• GoldenRatio minimization for CC algorithm:

More details: https://en.wikipedia.org/wiki/Golden-section_search

• Implementation of kOOT flag for spike rejection:

More details: https://indico.cern.ch/event/1114550/contributions/4887537/attachments/2451361/4200675/ECAL_DPG_25May22.pdf

A proposed test script is available here:
https://github.com/nminafra/cmssw/blob/ecalTimingCC_12_6_0_pre4/RecoLocalCalo/EcalRecProducers/test/testEcalUncalibRechitProducerWithCC_cfg.py

Profiling of the CC (this PR) and Ratio (default) are available here:
https://nminafra.web.cern.ch/cgi-bin/igprof-navigator/igreport_cc_Nov2022/20
https://nminafra.web.cern.ch/cgi-bin/igprof-navigator/igreport_ratio_Nov2022/20

CC has to run twice: once with OOT correction for better timing, a second time without OOT corrections for better spike rejection (see presentation above). Even running twice, CC is faster than Ratio.

@thomreis @jking79

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40262/33313

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @nminafra (Nicola Minafra) for master.

It involves the following packages:

• RecoLocalCalo/EcalRecAlgos (reconstruction)
• RecoLocalCalo/EcalRecProducers (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@youyingli, @apsallid, @rchatter, @argiro, @missirol, @thomreis, @simonepigazzini this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[thomreis]

type ecal

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c8e91/29521/summary.html
COMMIT: 81ccc21
CMSSW: CMSSW_13_0_X_2022-12-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40262/29521/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 30 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3421214
• DQMHistoTests: Total failures: 1192
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3420000
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[clacaputo]

enable profiling

[nminafra]

Thank you @nminafra

You can now also remove https://github.com/cms-sw/cmssw/pull/40262/files#diff-a4f025f32fe02059a83e7acaa21d1884c35d899663994e907b0795f585e02c0dR72-R73

true, thanks!

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40262/33692

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #40262 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c8e91/29963/summary.html
COMMIT: 0489962
CMSSW: CMSSW_13_0_X_2023-01-12-2300/el8_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40262/29963/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555510
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c8e91/29963/summary.html
COMMIT: 0489962
CMSSW: CMSSW_13_0_X_2023-01-12-2300/el8_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40262/29963/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555510
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

re-sign

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1