Protect TFile in HFShowerLibrary from thread-local context

[Dr15Jones]

PR description:

ROOT does not support opening a TFile on one thread and deleting it on another. A work around is to avoid having the TFile's context be permanently added to the thread local context list.

PR validation:

Code compiles

fixes #40290

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40296/33365

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• SimG4CMS/Calo (simulation)

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @bsunanda, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-104c1b/29581/summary.html
COMMIT: 7f50678
CMSSW: CMSSW_13_0_X_2022-12-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40296/29581/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3421510
• DQMHistoTests: Total failures: 149
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3421339
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

The comparison differences are in 11634.7 and thus likely spurious (#39803)

[perrotta]

@cms-sw/simulation-l2 could you please evaluate this PR in time for possibly including it in the 1100 IB? Thank you!

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1