Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TF session in L1Trigger/L1NNTauProducer to global cache #40333

Merged
merged 3 commits into from Dec 19, 2022

Conversation

riga
Copy link
Contributor

@riga riga commented Dec 15, 2022

PR description

This PR adapts the L1NNTauProducer and TauNNId helper object in L1Trigger to use a single, const tensorflow session stored in the global cache. For this, it's using the central SessionCache struct introduced in #40284.

This is part of the planned changes documented in #40248, intended to treat all tf sessions as constant for model evaluation purposes and therefore preventing copies across stream module instances for saving memory.

PR validation

There was no new functionality added to the L1NNTauProducer, so existing test cases should fully cover the changes.

@clacaputo @yongbinfeng @valsdav

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40333/33418

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @riga (Marcel R.) for master.

It involves the following packages:

  • L1Trigger/Phase2L1ParticleFlow (upgrade, l1)

@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @beaucero, @trtomei this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40333/33428

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40333 was updated. @rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please check and sign again.

@srimanob
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b42873/29668/summary.html
COMMIT: ce1a224
CMSSW: CMSSW_13_0_X_2022-12-16-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40333/29668/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 35 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557521
  • DQMHistoTests: Total failures: 1197
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3556302
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@AdrianoDee
Copy link
Contributor

+upgrade
Technical

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9318eb0 into cms-sw:master Dec 19, 2022
@riga riga deleted the use_global_session_L1Trigger branch December 19, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants