New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TF session in L1Trigger/L1NNTauProducer to global cache #40333
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40333/33418
|
A new Pull Request was created by @riga (Marcel R.) for master. It involves the following packages:
@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40333/33428
|
Pull request #40333 was updated. @rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b42873/29668/summary.html Comparison SummarySummary:
|
+l1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description
This PR adapts the
L1NNTauProducer
andTauNNId
helper object inL1Trigger
to use a single, const tensorflow session stored in the global cache. For this, it's using the centralSessionCache
struct introduced in #40284.This is part of the planned changes documented in #40248, intended to treat all tf sessions as constant for model evaluation purposes and therefore preventing copies across stream module instances for saving memory.
PR validation
There was no new functionality added to the
L1NNTauProducer
, so existing test cases should fully cover the changes.@clacaputo @yongbinfeng @valsdav