Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[125X] Update Run3 offline and offline RelVal GTs #40338

Merged

Conversation

saumyaphor4252
Copy link
Contributor

PR description:

Backport of #40318

This PR updates the offline GT (auto:run3_data) and the offline relval GT (auto:run3_data_relval) with:

  • latest conditions to be used for the 2022E Re-Reco (CMSTalk post) [1]
  • updated HCAL QIED conditions requested in (CMSTalk post)[2]
  • Removal of some MVASelector tags for tracking following (CMSTalk post)[3]

[1] https://cms-talk.web.cern.ch/t/offline-call-for-offline-conditions-for-the-2022e-re-reco/17856/2
[2] https://cms-talk.web.cern.ch/t/gt-offline-request-of-updating-replacing-hcal-offline-conditions/18539
[3] https://cms-talk.web.cern.ch/t/proposal-of-removal-of-bdt-based-gbrwrapperrcd-tags-for-tracking-selection-from-run-3-globaltags/16757

GT differences:

Run 3 data (offline)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_v14/124X_dataRun3_v11

Run 3 data RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_dataRun3_relval_v6/125X_dataRun3_relval_v4

Diff between new offline and new offline_relval GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_v14/125X_dataRun3_relval_v6

PR validation:

Successfully ran:
runTheMatrix.py -l 139.001 --ibeos -j 4
which consumes the relval GT.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #40318

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for CMSSW_12_5_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b70343/29642/summary.html
COMMIT: 0f4d836
CMSSW: CMSSW_12_5_X_2022-12-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40338/29642/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 161 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3724047
  • DQMHistoTests: Total failures: 91
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3723933
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 216 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@saumyaphor4252 @malbouis
rereco is going to be started with 12_4_X: is there any reason why this update is not propagated to 12_4_X?

@tvami
Copy link
Contributor

tvami commented Dec 18, 2022

@saumyaphor4252 @malbouis rereco is going to be started with 12_4_X: is there any reason why this update is not propagated to 12_4_X?

Hi Andrea, yes, we should (and will) do that as well

@malbouis
Copy link
Contributor

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@perrotta the backport was just submitted: #40366
Thanks!

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6dca65a into cms-sw:CMSSW_12_5_X Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants