Refactor SiPixel Charge Reweighting code #40349

tvami · 2022-12-16T19:44:28Z

PR description:

Refactoring Charge Reweighting code so it can be used in a follow-up PR in the Phase-2 simulations.
Changes to obey some of the coding rules that I came accross in these codes, like 2.7 and 4.1, 6.1
Ran code-checks and code-format
For now this should lead to no changes.

PR validation:

Tested a Phase-1 and a Phase-2 wf:

12034.0_TTbar_14TeV+2021Design Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Fri Dec 16 18:51:23 2022-date Fri Dec 16 18:36:24 2022; exit: 0 0 0 0
20834.0_TTbar_14TeV+2026D88 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Dec 16 18:59:10 2022-date Fri Dec 16 18:36:25 2022; exit: 0 0 0 0 0
2 2 2 2 1 tests passed, 0 0 0 0 0 failed

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport and no backport is needed

cmsbuild · 2022-12-16T19:53:01Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40349/33438

ERROR: Build errors found during clang-tidy run.

Suppressed 390 warnings (389 in non-user code, 1 with check filters).
--
SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizerAlgorithm.h:16:10: error: 'SimTracker/Common/interface/DigitizerUtility.h' file not found [clang-diagnostic-error]
#include "SimTracker/Common/interface/DigitizerUtility.h"
         ^
Suppressed 402 warnings (401 in non-user code, 1 with check filters).
--
SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizerAlgorithm.h:16:10: error: 'SimTracker/Common/interface/DigitizerUtility.h' file not found [clang-diagnostic-error]
#include "SimTracker/Common/interface/DigitizerUtility.h"
         ^
Suppressed 404 warnings (403 in non-user code, 1 with check filters).
--
SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizerAlgorithm.h:16:10: error: 'SimTracker/Common/interface/DigitizerUtility.h' file not found [clang-diagnostic-error]
#include "SimTracker/Common/interface/DigitizerUtility.h"
         ^
Suppressed 769 warnings (768 in non-user code, 1 with check filters).
--
SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizerAlgorithm.cc:87:10: error: 'SimTracker/Common/interface/SiPixelChargeReweightingAlgorithm.h' file not found [clang-diagnostic-error]
#include "SimTracker/Common/interface/SiPixelChargeReweightingAlgorithm.h"
         ^
Suppressed 745 warnings (744 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2022-12-16T20:00:03Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40349/33439

ERROR: Build errors found during clang-tidy run.

Suppressed 402 warnings (401 in non-user code, 1 with check filters).
--
SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizerAlgorithm.h:16:10: error: 'SimTracker/Common/interface/DigitizerUtility.h' file not found [clang-diagnostic-error]
#include "SimTracker/Common/interface/DigitizerUtility.h"
         ^
Suppressed 390 warnings (389 in non-user code, 1 with check filters).
--
SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizerAlgorithm.h:16:10: error: 'SimTracker/Common/interface/DigitizerUtility.h' file not found [clang-diagnostic-error]
#include "SimTracker/Common/interface/DigitizerUtility.h"
         ^
Suppressed 404 warnings (403 in non-user code, 1 with check filters).
--
SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizerAlgorithm.h:16:10: error: 'SimTracker/Common/interface/DigitizerUtility.h' file not found [clang-diagnostic-error]
#include "SimTracker/Common/interface/DigitizerUtility.h"
         ^
Suppressed 769 warnings (768 in non-user code, 1 with check filters).
--
SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizerAlgorithm.cc:87:10: error: 'SimTracker/Common/interface/SiPixelChargeReweightingAlgorithm.h' file not found [clang-diagnostic-error]
#include "SimTracker/Common/interface/SiPixelChargeReweightingAlgorithm.h"
         ^
Suppressed 745 warnings (744 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2022-12-16T20:10:21Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40349/33442

This PR adds an extra 80KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40349/33442/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40349/33442/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40349/33442/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40349/33442/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-12-16T20:18:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40349/33443

This PR adds an extra 80KB to repository

tvami · 2022-12-19T00:22:39Z

Nice, differences in MsgLogger only (as expected)
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_0_X_2022-12-18-0000+4ce99d/54725/validateJR.html

mmusich · 2022-12-19T08:45:19Z

test parameters:

enable_test = threading
workflows_threading = 250202.182, 250202.184

mmusich · 2022-12-19T08:45:26Z

@cmsbuild, please test

mmusich · 2022-12-19T10:07:13Z

type trk

cmsbuild · 2022-12-19T12:54:34Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ce99d/29683/summary.html
COMMIT: ec4ca15
CMSSW: CMSSW_13_0_X_2022-12-18-2300/el8_amd64_gcc11
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40349/29683/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555748
DQMHistoTests: Total failures: 154
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555572
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-12-19T19:31:05Z

hi @cms-sw/upgrade-l2 @cms-sw/simulation-l2 @cms-sw/orp-l2 is there a chance we could merge this before the winter break? In the end it's a very technical PR that doesnt change the physics output, but I'd need it for a follow-up PR

civanch · 2022-12-20T08:05:21Z

+1

updates are technical mostly

srimanob · 2022-12-20T15:56:31Z

+Upgrade

Technical PR, change is not expected. Failure in comparison does not come from this PR.

cmsbuild · 2022-12-20T15:56:56Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-12-20T16:09:49Z

+1

tvami changed the title ~~Refactor Charge Reweighting code~~ Refactor SiPixelCharge Reweighting code Dec 16, 2022

cmsbuild added this to the CMSSW_13_0_X milestone Dec 16, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Dec 16, 2022

tvami changed the title ~~Refactor SiPixelCharge Reweighting code~~ Refactor SiPixel Charge Reweighting code Dec 16, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Dec 16, 2022

tvami force-pushed the RefactorChargeRew branch from b497aa2 to 75bf0e8 Compare December 16, 2022 19:54

cmsbuild added code-checks-pending and removed code-checks-rejected labels Dec 16, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Dec 16, 2022

tvami force-pushed the RefactorChargeRew branch from 75bf0e8 to 84b0601 Compare December 16, 2022 20:05

cmsbuild added code-checks-pending and removed code-checks-rejected labels Dec 16, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Dec 16, 2022

tvami force-pushed the RefactorChargeRew branch from 84b0601 to 3922cea Compare December 16, 2022 20:13

cmsbuild added code-checks-pending and removed code-checks-rejected labels Dec 16, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 16, 2022

cmsbuild added the tests-approved label Dec 19, 2022

cmsbuild added tests-started and removed tests-approved labels Dec 19, 2022

cmsbuild added the trk label Dec 19, 2022

cmsbuild added tests-approved and removed tests-started labels Dec 19, 2022

cmsbuild added simulation-approved and removed simulation-pending labels Dec 20, 2022

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Dec 20, 2022

cmsbuild added orp-approved and removed orp-pending labels Dec 20, 2022

cmsbuild merged commit 8b5b318 into cms-sw:master Dec 20, 2022

This was referenced Dec 20, 2022

Add missing dependencies on TBB #40376

Merged

Add dictionaries for FindUsingAdvance in TrackReco #40377

Merged

[ROOT626] Root update v6 26 00 patches 20221220 cms-sw/cmsdist#8239

Closed

Add dictionaries for AtomicPtrCache #40379

Merged

tvami mentioned this pull request Jan 2, 2023

Include charge reweighting for Phase-2 IT planar sensors #40417

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor SiPixel Charge Reweighting code #40349

Refactor SiPixel Charge Reweighting code #40349

tvami commented Dec 16, 2022 •

edited

cmsbuild commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

tvami commented Dec 19, 2022 •

edited

mmusich commented Dec 19, 2022

mmusich commented Dec 19, 2022

mmusich commented Dec 19, 2022

cmsbuild commented Dec 19, 2022

tvami commented Dec 19, 2022

civanch commented Dec 20, 2022

srimanob commented Dec 20, 2022

cmsbuild commented Dec 20, 2022

perrotta commented Dec 20, 2022

Refactor SiPixel Charge Reweighting code #40349

Refactor SiPixel Charge Reweighting code #40349

Conversation

tvami commented Dec 16, 2022 • edited

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

cmsbuild commented Dec 16, 2022

tvami commented Dec 19, 2022 • edited

mmusich commented Dec 19, 2022

mmusich commented Dec 19, 2022

mmusich commented Dec 19, 2022

cmsbuild commented Dec 19, 2022

Comparison Summary

tvami commented Dec 19, 2022

civanch commented Dec 20, 2022

srimanob commented Dec 20, 2022

cmsbuild commented Dec 20, 2022

perrotta commented Dec 20, 2022

tvami commented Dec 16, 2022 •

edited

tvami commented Dec 19, 2022 •

edited