Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test to check availability of EDM files used in HLT tests #40365

Merged
merged 1 commit into from Dec 20, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Dec 19, 2022

PR description:

The PRs to fix #40013 updated the HLT tests to use the standard LFNs of their EDM input files. This failed to cover one use case of TSG: running locally an extended version of the HLT tests which requires access to EDM files not used in IBs of any release cycles. Since these files are not used in IBs, they might eventually be removed from the IB-EOS cache, causing said local tests to fail if the EDM files are not available at any other T2/T3.

This PR adds a unit test which accesses each of the EDM files needed for (the extended version of the) HLT tests. In practise, this serves as a trick to ensure that the cmsbot keeps these files cached in the IB-EOS area. The list of relevant EDM files is maintained in a text file, which can be updated by locally executing a script (the unit test does not modify the text file with the list of EDM files, it only uses it). A readme with further details is added under test/.

PR validation:

The new unit test passes.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40365/33464

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol missirol changed the title added unit test to check availability of EDM files used in HLT tests add unit test to check availability of EDM files used in HLT tests Dec 19, 2022
@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b25b8/29695/summary.html
COMMIT: 4c2fe56
CMSSW: CMSSW_13_0_X_2022-12-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40365/29695/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
20034.61 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 29 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555748
  • DQMHistoTests: Total failures: 1188
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554538
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40365/33475

@cmsbuild
Copy link
Contributor

Pull request #40365 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

@missirol
Copy link
Contributor Author

please test

its implementation might be improved in the future.

The latest push includes some improvements to the update_filelist script (mainly, formatting changes). This latest update won't have any impact on PR tests (which will be repeated nonetheless). I don't plan to make further changes to this PR.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40365/33483

@cmsbuild
Copy link
Contributor

Pull request #40365 was updated. @Martin-Grunewald, @missirol can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b25b8/29710/summary.html
COMMIT: 7b5e4e0
CMSSW: CMSSW_13_0_X_2022-12-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40365/29710/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555748
  • DQMHistoTests: Total failures: 154
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555572
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

The new unit test passes. The RelVals-INPUT error can't be related to this PR (by construction).

PS. Only a few RelVal-input wfs were missing when the 4h-timeout hit. I wonder if increasing this timeout limit a bit could decrease significantly the rate of these spurious errors.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HLT-Validation tests failing in IBs of CMSSW <= 12_1_X
3 participants