New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit test to check availability of EDM files used in HLT tests #40365
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40365/33464
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b25b8/29695/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
4c2fe56
to
5161667
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40365/33475
|
Pull request #40365 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again. |
please test |
please test
The latest push includes some improvements to the |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40365/33483
|
Pull request #40365 was updated. @Martin-Grunewald, @missirol can you please check and sign again. |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
+hlt The new unit test passes. The RelVals-INPUT error can't be related to this PR (by construction). PS. Only a few RelVal-input wfs were missing when the 4h-timeout hit. I wonder if increasing this timeout limit a bit could decrease significantly the rate of these spurious errors. |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
The PRs to fix #40013 updated the HLT tests to use the standard LFNs of their EDM input files. This failed to cover one use case of TSG: running locally an extended version of the HLT tests which requires access to EDM files not used in IBs of any release cycles. Since these files are not used in IBs, they might eventually be removed from the IB-EOS cache, causing said local tests to fail if the EDM files are not available at any other T2/T3.
This PR adds a unit test which accesses each of the EDM files needed for (the extended version of the) HLT tests. In practise, this serves as a trick to ensure that the cmsbot keeps these files cached in the IB-EOS area. The list of relevant EDM files is maintained in a text file, which can be updated by locally executing a script (the unit test does not modify the text file with the list of EDM files, it only uses it). A readme with further details is added under
test/
.PR validation:
The new unit test passes.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
N/A