Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zmumumerge: post-merge comments to #40346 #40371

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 20, 2022

PR description:

Quick follow-up to #40346 (comment)

PR validation:

It compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40371/33488

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Dec 20, 2022

@cmsbuild , please test

@mmusich
Copy link
Contributor Author

mmusich commented Dec 20, 2022

@cmsbuild , please test

Sometimes (as in this case) running the full limited relval matrix and comparisons is a waste of resources, when what you really want is static analyzer + unit tests.
I am wondering if such a functionality could be provided, perhaps with the addition of a new flag (e.g. limited-tests-passed)

@tvami
Copy link
Contributor

tvami commented Dec 20, 2022

I understand that the static analyzer + unit tests are run before the relval matrix, so for now we could just abort after that part is done, what do you think? It wont lead to nice labels tho

@mmusich
Copy link
Contributor Author

mmusich commented Dec 20, 2022

what do you think

I was envisaging a more general solution

@tvami
Copy link
Contributor

tvami commented Dec 20, 2022

+alca

  • unit test testing the change already passed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53a853/29722/summary.html
COMMIT: 375e8a4
CMSSW: CMSSW_13_0_X_2022-12-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40371/29722/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 25 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555748
  • DQMHistoTests: Total failures: 1188
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554538
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8ec31d4 into cms-sw:master Dec 20, 2022
@mmusich mmusich deleted the DiMuonValidationInAlignmentOfflineValidation_13_0_X branch December 20, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants