New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zmumumerge
: post-merge comments to #40346
#40371
Zmumumerge
: post-merge comments to #40346
#40371
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40371/33488
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
Sometimes (as in this case) running the full limited relval matrix and comparisons is a waste of resources, when what you really want is static analyzer + unit tests. |
I understand that the static analyzer + unit tests are run before the relval matrix, so for now we could just abort after that part is done, what do you think? It wont lead to nice |
I was envisaging a more general solution |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53a853/29722/summary.html Comparison SummarySummary:
|
+1 |
PR description:
Quick follow-up to #40346 (comment)
PR validation:
It compiles.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A