Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TaggedProton filter for analysis with tagged protons [10_6_X] #40415

Merged
merged 2 commits into from Feb 7, 2023

Conversation

michael-pitt
Copy link
Contributor

@michael-pitt michael-pitt commented Jan 2, 2023

This is backport from PR #40083

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 2, 2023

A new Pull Request was created by @michael-pitt (Michael Pitt) for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/Core (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jan 8, 2023

backport of #40083

@menglu21
Copy link
Contributor

menglu21 commented Feb 6, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7aa320/30417/summary.html
COMMIT: 0ba2b4d
CMSSW: CMSSW_10_6_X_2023-02-05-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40415/30417/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 102 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

menglu21 commented Feb 7, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 7, 2023

+1

  • New filter added

@cmsbuild cmsbuild merged commit d3d76d3 into cms-sw:CMSSW_10_6_X Feb 7, 2023
@perrotta
Copy link
Contributor

perrotta commented Feb 7, 2023

@michael-pitt @menglu21 @Saptaparna please notice that this filter is merged in master since 13_0_X and only backported to 10_6_X here. If needed for any other intermediate release, additional backports are in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants