Avoid including RooChi2Var.h in CMSSW

[guitargeek]

The direct inclusion of the RooChi2Var.h header will soon result in a warning with ROOT master.

Users will be encouraged to always use RooAbsPdf::createChi2() instead of instantiating the chi-square-representing objects themselves.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40442/33590

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)
• DQMOffline/Trigger (dqm)
• MuonAnalysis/MomentumScaleCalibration (alca)

@malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@Fedespring, @adewit, @rchatter, @mtosi, @JanFSchulte, @tocheng, @argiro, @bellan, @HuguesBrun, @jhgoh, @thomreis, @tlampen, @simonepigazzini, @missirol, @trocino, @mmusich, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a06fc/29818/summary.html
COMMIT: f9735de
CMSSW: CMSSW_13_0_X_2023-01-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40442/29818/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555748
• DQMHistoTests: Total failures: 154
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555572
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

• technical PR
• WF 11634.7 differences spurious

[perrotta]

@guitargeek shouldn't you #include "RooAbsReal.h" in all three classes that you modified?

[guitargeek]

RooAbsReal is the base class of all other RooFit classes that you can build models with (like RooGaussian, RooAddPdf, so it will always be indirectly included anyway if you use RooFit

[guitargeek]

Updating the PR because there were conflicts

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40442/33632

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #40442 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a06fc/29871/summary.html
COMMIT: 99bfbbe
CMSSW: CMSSW_13_0_X_2023-01-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40442/29871/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 30 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 1188
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554328
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• technical change

[tvami]

let me also point out to our @cms-sw/dqm-l2 friends that there is a coding rule violation in /DQMOffline/Trigger/plugins/GenericTnPFitter.h
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a06fc/29871/codeRules/cmsCodeRule1.txt

[guitargeek]

@emanueleusai, sorry that I had to push again because of conflicts. Can you please approve this PR again?

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1