New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for cross-site catalog access #40569
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40569/33809
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b3d29/30079/summary.html Comparison SummarySummary:
|
@Dr15Jones Could you take a look? |
My only comment is I'd prefer if the various 'site' files were in a separate sub-directory of test just to keep the test directory less cluttered. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40569/33899
|
Pull request #40569 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again. |
01c6300
to
11bcbf5
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40569/33901
|
Pull request #40569 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again. |
@cmsbuild, please test Organized the files better. |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
+1 RelVals-INPUT tests timed out, nothing in this PR can impact those (and I'm leaning towards retesting not being worth it). |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
While investigating https://ggus.eu/index.php?mode=ticket_info&ticket_id=160073 I realized we didn't have a test for the cross-site catalog access (that is used in the wild at least for specifying the xrootd fallback). This PR adds such a test.
PR validation:
Unit test succeeds.