Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix N-dimensional strided loops and extend the alpaka tests #40598

Merged
merged 3 commits into from Jan 24, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 23, 2023

PR description:

Implement an N-dimensional vector add test with alpaka and cms::alpakatools utilities.
Refactor the checks for accelerators that support multiple threads per block (e.g. GPUs) or a single thread with multiple elements (e.g. serial CPUs), and use the new constant to simplify the workdiv generation and the strided loops.

PR validation:

The new unit tests pass.

@fwyzard fwyzard changed the title Fix N-dimensional strided loops and extend the alpaka vector add tests Fix N-dimensional strided loops and extend the alpaka tests Jan 23, 2023
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Jan 23, 2023
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2023

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2023

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2023

This PR continue the work done in #40580, adding more tests for N-dimensional loops.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40598/33852

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2023

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2023

+heterogeneous

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40598/33853

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

Implement an N-dimensional vector add test with alpaka and cms::alpakatools
utilities.
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2023

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2023

+heterogeneous

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40598/33854

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5ef8e/30135/summary.html
COMMIT: 4eaaf65
CMSSW: CMSSW_13_0_X_2023-01-23-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40598/30135/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555473
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 256
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19606
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants