Implement a first draft of the ROCmServices

[fwyzard]

PR description:

Implement a first draft of the ROCmService and ROCmMonitoringService.

While the ROCmService is not on par with the CUDAService, it is already usable, especially for the ROCm library tests and as the basis to implement more ROCm utilities.

The commented out code is left as a reminder of the CUDAService features that are still missing.

The PR builds on top of and includes:

• Add ROCm utilities and tests, and CUDA fallbacks #40619

PR validation:

The new unit tests pass.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40642/33945

ERROR: Build errors found during clang-tidy run.

HeterogeneousCore/ROCmServices/src/ROCmService.cc:20:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 517 warnings (516 in non-user code, 1 with check filters).
--
HeterogeneousCore/ROCmServices/plugins/ROCmMonitoringService.cc:15:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 548 warnings (547 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[fwyzard]

This PR requires #40619 .

[fwyzard]

please test with cms-sw/cmsdist#8273,#40619

[fwyzard]

please test

[fwyzard]

+heterogeneous

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40642/33987

ERROR: Build errors found during clang-tidy run.

HeterogeneousCore/ROCmServices/src/ROCmService.cc:20:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 518 warnings (517 in non-user code, 1 with check filters).
--
HeterogeneousCore/ROCmServices/plugins/ROCmMonitoringService.cc:15:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 549 warnings (548 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[fwyzard]

Ah... so the code checks use the latest IB as-is, without the PRs that have already been merged :-(

[fwyzard]

please test

[fwyzard]

+heterogeneous

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40642/33991

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HeterogeneousCore/ROCmServices/BuildFile.xml modified in PR(s): Add a test for ROCm libraries and build rules #40637
  • File HeterogeneousCore/ROCmServices/interface/ROCmService.h modified in PR(s): Add a test for ROCm libraries and build rules #40637
  • File HeterogeneousCore/ROCmServices/plugins/BuildFile.xml modified in PR(s): Add a test for ROCm libraries and build rules #40637
  • File HeterogeneousCore/ROCmServices/plugins/ROCmMonitoringService.cc modified in PR(s): Add a test for ROCm libraries and build rules #40637
  • File HeterogeneousCore/ROCmServices/plugins/plugins.cc modified in PR(s): Add a test for ROCm libraries and build rules #40637
  • File HeterogeneousCore/ROCmServices/src/ROCmService.cc modified in PR(s): Add a test for ROCm libraries and build rules #40637
  • File HeterogeneousCore/ROCmServices/test/BuildFile.xml modified in PR(s): Add a test for ROCm libraries and build rules #40637
  • File HeterogeneousCore/ROCmServices/test/testROCmService.cpp modified in PR(s): Add a test for ROCm libraries and build rules #40637
  • File HeterogeneousCore/ROCmServices/test/testROCmService.py modified in PR(s): Add a test for ROCm libraries and build rules #40637

[cmsbuild]

Pull request #40642 was updated. can you please check and sign again.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8bc51/30326/summary.html
COMMIT: 4f5ff35
CMSSW: CMSSW_13_0_X_2023-01-31-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40642/30326/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555495
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555467
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[perrotta]

merge