Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against no L1T uGT digis in L1TriggerResultsConverter [12_4_X] #40651

Merged
merged 1 commit into from Feb 1, 2023

Conversation

missirol
Copy link
Contributor

backport of #40528

PR description:

This PR fixes the edge case reported in #40494. It adds a check on the size of the L1T uGT digis, returning false for all L1T algorithms when said input collection has 0 elements for the relevant BX (see #40528 (comment) for details).

PR validation:

None beyond the checks done for #40528.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#40528

Bugfix to NanoAOD.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_4_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

type bugfix

@missirol
Copy link
Contributor Author

enable nano

@missirol
Copy link
Contributor Author

please test

@missirol
Copy link
Contributor Author

please abort

Looks like "enable nano" is not an option in 12_4_X.

@missirol
Copy link
Contributor Author

please test

@missirol
Copy link
Contributor Author

please abort

I should 'disable nano'..

@missirol
Copy link
Contributor Author

enable none

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce2e3f/30305/summary.html
COMMIT: 16a45bc
CMSSW: CMSSW_12_4_X_2023-01-29-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40651/30305/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2113 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3766053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@swertz
Copy link
Contributor

swertz commented Feb 1, 2023

+1

verbatim backport.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 1, 2023

+1

@cmsbuild cmsbuild merged commit 8c93a95 into cms-sw:CMSSW_12_4_X Feb 1, 2023
@missirol missirol deleted the devel_fix40494_124X branch February 2, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants