Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Lorentz Angle Prompt Calibration Loop for Pixel Forward Phase 1 detector #40664

Merged
merged 3 commits into from Feb 9, 2023

Conversation

tsusa
Copy link
Contributor

@tsusa tsusa commented Feb 1, 2023

PR description:

This PR introduces the Lorentz Angle (LA) Prompt Calibration Loop for the Pixel Forward Phase 1 detector (FPIX). In FPIX, LA is measured using the Minimal Cluster Size method.
The SiPixelLorentzAnglePCLWorker creates 16 2D cluster size x/y vs cot(alpha/beta) histograms and 16x3 magnetic field components histograms. In SiPixelLorentzAnglePCHarvesterMCS the cluster size x/y vs cot(alpha/beta) histograms are used to generate 1D profiles (average cluster size x/y vs cot(alpha/beta)) which are then fit and the values of the cot (alpha/beta) for which the cluster sizes are minimal are determined. The obtained cot(alpha/beta)_min value for z- and z+ side are used to perform fit to determine muH for different rings and panels of the Pixel Forward Phase 1 detector using the formulas:
cot(alpha)_min = vx/vz = (muHBy + muH^2xBzBx)/(1+muH^2Bz^2)
cot(beta)_min = vy/vz = -(muHBx - muH^2xBzBx)/(1+muH^2Bz^2)

PR validation:

With the new wf 1052
runTheMatrix -l 1052

@tlampen, @mmusich, @ferencek

@mmusich
Copy link
Contributor

mmusich commented Feb 1, 2023

test parameters:

  • workflows = 1001.0, 1001.2, 1052, 1052.1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40664/34003

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40664/34004

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

A new Pull Request was created by @tsusa (Tatjana Susa) for master.

It involves the following packages:

  • CalibTracker/SiPixelLorentzAngle (alca)
  • Calibration/TkAlCaRecoProducers (alca)
  • Configuration/AlCa (alca)
  • Configuration/EventContent (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@perrotta, @malbouis, @rappoccio, @yuanchao, @bbilin, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @francescobrivio, @ChrisMisan, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @kpedro88, @argiro, @Martin-Grunewald, @thomreis, @threus, @slomeo, @makortel, @JanFSchulte, @dgulhan, @missirol, @simonepigazzini, @GiacomoSguazzoni, @rovere, @VinInn, @mroguljic, @ferencek, @tocheng, @mmusich, @mtosi, @fabiocos, @rchatter, @dkotlins, @sameasy, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Feb 1, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c4a2f/30339/summary.html
COMMIT: 859a0de
CMSSW: CMSSW_13_0_X_2023-01-31-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40664/30339/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555473
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Feb 1, 2023

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Feb 6, 2023

+1

  • tests pass, including the new dedicated ones

@tvami
Copy link
Contributor

tvami commented Feb 6, 2023

urgent

  • backport needed for cosmics data taking

@mmusich
Copy link
Contributor

mmusich commented Feb 8, 2023

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you please take a look to the change in Configuration/PyReleaseValidation in order to test the new workflow?

@kskovpen
Copy link
Contributor

kskovpen commented Feb 8, 2023

+pdmv

@AdrianoDee
Copy link
Contributor

+upgrade
(everything fine for the wfs under Configuration/PyReleaseValidation)

@tvami
Copy link
Contributor

tvami commented Feb 8, 2023

@cms-sw/orp-l2 we are essentially fully signed

@francescobrivio
Copy link
Contributor

@tsusa Hi Tanja, since this is now fully signed and will be merged soon in master could you open the backport to 12_6_X?
Thanks a lot!

And a kind ping to @cms-sw/orp-l2 to merge this before cutting 13_0_0_pre4 😄

@perrotta
Copy link
Contributor

perrotta commented Feb 9, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants