New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Lorentz Angle Prompt Calibration Loop for Pixel Forward Phase 1 detector #40664
Conversation
test parameters:
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40664/34003
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40664/34004
|
A new Pull Request was created by @tsusa (Tatjana Susa) for master. It involves the following packages:
@perrotta, @malbouis, @rappoccio, @yuanchao, @bbilin, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @francescobrivio, @ChrisMisan, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
@cmsbuild , please test |
+1
|
urgent
|
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you please take a look to the change in |
+pdmv |
+upgrade |
@cms-sw/orp-l2 we are essentially fully signed |
@tsusa Hi Tanja, since this is now fully signed and will be merged soon in master could you open the backport to 12_6_X? And a kind ping to @cms-sw/orp-l2 to merge this before cutting 13_0_0_pre4 😄 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR introduces the Lorentz Angle (LA) Prompt Calibration Loop for the Pixel Forward Phase 1 detector (FPIX). In FPIX, LA is measured using the Minimal Cluster Size method.
The SiPixelLorentzAnglePCLWorker creates 16 2D cluster size x/y vs cot(alpha/beta) histograms and 16x3 magnetic field components histograms. In SiPixelLorentzAnglePCHarvesterMCS the cluster size x/y vs cot(alpha/beta) histograms are used to generate 1D profiles (average cluster size x/y vs cot(alpha/beta)) which are then fit and the values of the cot (alpha/beta) for which the cluster sizes are minimal are determined. The obtained cot(alpha/beta)_min value for z- and z+ side are used to perform fit to determine muH for different rings and panels of the Pixel Forward Phase 1 detector using the formulas:
cot(alpha)_min = vx/vz = (muHBy + muH^2xBzBx)/(1+muH^2Bz^2)
cot(beta)_min = vy/vz = -(muHBx - muH^2xBzBx)/(1+muH^2Bz^2)
PR validation:
With the new wf 1052
runTheMatrix -l 1052
@tlampen, @mmusich, @ferencek