Phase2-hgx335Q Add tests to investigate non-zero cassette shift in HGCal geometry

[bsunanda]

PR description:

Add tests to investigate non-zero cassette shift in HGCal geometry

PR validation:

Use the new test code for investigating non-zero cassette

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40684/34039

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40684/34039/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40684/34039/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40684/34040

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)
• SimG4CMS/Calo (simulation)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b1b17/30384/summary.html
COMMIT: bbab9cd
CMSSW: CMSSW_13_0_X_2023-02-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40684/30384/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 20834.0

----- Begin Fatal Exception 03-Feb-2023 16:07:21 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of Verbosity is expected to be bool but declared as int32
----- End Fatal Exception -------------------------------------------------

• 20834.75

----- Begin Fatal Exception 03-Feb-2023 16:09:28 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of Verbosity is expected to be bool but declared as int32
----- End Fatal Exception -------------------------------------------------

• 20834.76

----- Begin Fatal Exception 03-Feb-2023 16:09:43 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of Verbosity is expected to be bool but declared as int32
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 20896.0
• 20900.0
• 21034.999
• 23234.0

RelVals-INPUT

The relvals timed out after 4 hours.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40684/34054

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #40684 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @AdrianoDee, @srimanob can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b1b17/30399/summary.html
COMMIT: 78782b2
CMSSW: CMSSW_13_0_X_2023-02-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40684/30399/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555495
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555470
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[bsunanda]

@srimanob Please sign this PR

[srimanob]

+Upgrade

Add tests for HGCAL geometry. No change in wf is expected from this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1