diphoton_hlt_filters_added #40711

Soumyatifr · 2023-02-07T03:16:33Z

Dear experts,
I have added the hlt_diphoton_filters which are essentially needed for the next iteraton of the NANOAOD production.
It is very urgent, can you kindly check and merged to the master branch.
Keeping Higgs to gamma/gamma convenor @lfinco here to keep track of it.
Thanks and let me know if you need anything else for this.

cmsbuild · 2023-02-07T03:22:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40711/34089

This PR adds an extra 16KB to repository

cmsbuild · 2023-02-07T03:22:59Z

A new Pull Request was created by @Soumyatifr for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

swertz · 2023-02-07T07:58:44Z

Thanks @Soumyatifr , quick question: do you really need separate bits for all the added filters, or could they regrouped using a logical OR, according to the threshold? ie:

hltEG30LIso60CaloId15b35eHE12R9Id50b80eEcalIsoLastFilter OR hltEG30Iso60CaloId15b35eR9Id50b90eHE12b10eR9Id50b80eEcalIsoFilter
hltEG22Iso60CaloId15b35eHE12R9Id50b80eTrackIsoUnseededLastFilter OR hltEG22R9Id85b90eHE12R9Id50b80eR9UnseededLastFilter

(perhaps using globbing, such as hltEG30*Filter or however restrictive it needs to be, see other examples in the file)

Soumyatifr · 2023-02-07T08:44:01Z

@swertz Thanks for your comments, actually we need the seperate information for the individual filters. I have consulted this with @lfinco also. So kindly keep them in seperate bits.
Thanks in advance.

swertz · 2023-02-07T08:51:54Z

enable nano

swertz · 2023-02-07T08:52:04Z

please test

cmsbuild · 2023-02-07T13:19:17Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfc580/30443/summary.html
COMMIT: 3547eea
CMSSW: CMSSW_13_0_X_2023-02-06-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40711/30443/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially removed 10 lines from the logs
Reco comparison results: 15 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 34
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555439
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 110 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 10829
DQMHistoTests: Total failures: 220
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 10609
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.232	2.232	0.001 ( +0.0% )	9.60	9.59	+0.1%	1.470	1.502
2500.311	2.323	2.323	0.000 ( +0.0% )	9.22	9.24	-0.3%	1.833	1.868
2500.312	2.277	2.277	-0.000 ( -0.0% )	9.33	9.38	-0.6%	1.826	1.859
2500.33	1.100	1.098	0.002 ( +0.2% )	22.14	21.76	+1.7%	1.638	1.641
2500.331	1.394	1.393	0.001 ( +0.1% )	16.11	15.86	+1.6%	1.790	1.791
2500.332	1.326	1.324	0.002 ( +0.1% )	18.12	17.81	+1.7%	1.844	1.846
2500.401	2.139	2.138	0.000 ( +0.0% )	10.42	10.37	+0.6%	1.158	1.193
2500.501	1.711	1.711	0.000 ( +0.0% )	16.55	16.67	-0.7%	1.083	1.087
2500.511	1.124	1.123	0.002 ( +0.2% )	31.25	29.73	+5.1%	1.360	1.357
2500.601	2.050	2.050	0.000 ( +0.0% )	12.63	12.48	+1.2%	1.136	1.151

swertz · 2023-02-07T14:38:13Z

please test

Retrying for timeouts

swertz · 2023-02-07T15:56:54Z

type egamma

cmsbuild · 2023-02-07T19:00:58Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfc580/30462/summary.html
COMMIT: 3547eea
CMSSW: CMSSW_13_0_X_2023-02-07-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40711/30462/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially added 13 lines to the logs
Reco comparison results: 14 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555852
DQMHistoTests: Total failures: 37
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555793
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 6 lines to the logs
Reco comparison results: 110 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 10829
DQMHistoTests: Total failures: 220
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 10609
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.232	2.232	0.001 ( +0.0% )	9.48	9.41	+0.7%	1.513	1.506
2500.311	2.323	2.323	0.000 ( +0.0% )	9.16	9.26	-1.1%	1.892	1.873
2500.312	2.277	2.277	-0.000 ( -0.0% )	9.39	9.33	+0.6%	1.883	1.873
2500.33	1.100	1.098	0.002 ( +0.2% )	21.42	21.42	+0.0%	1.637	1.640
2500.331	1.394	1.393	0.001 ( +0.1% )	15.82	15.85	-0.2%	1.787	1.786
2500.332	1.326	1.324	0.002 ( +0.1% )	17.94	17.73	+1.2%	1.847	1.848
2500.401	2.139	2.138	0.000 ( +0.0% )	10.49	10.42	+0.7%	1.197	1.192
2500.501	1.711	1.711	0.000 ( +0.0% )	16.43	16.72	-1.7%	1.135	1.119
2500.511	1.124	1.123	0.002 ( +0.2% )	29.62	29.14	+1.7%	1.376	1.369
2500.601	2.050	2.050	0.000 ( +0.0% )	12.39	12.46	-0.6%	1.189	1.172

swertz · 2023-02-08T07:57:53Z

please test

cmsbuild · 2023-02-08T10:27:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfc580/30484/summary.html
COMMIT: 3547eea
CMSSW: CMSSW_13_0_X_2023-02-07-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40711/30484/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 23 lines to the logs
Reco comparison results: 22 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555852
DQMHistoTests: Total failures: 43
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555787
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 7 lines from the logs
Reco comparison results: 110 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 10829
DQMHistoTests: Total failures: 220
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 10609
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.232	2.232	0.001 ( +0.0% )	9.65	9.66	-0.1%	1.472	1.508
2500.311	2.323	2.323	0.000 ( +0.0% )	9.23	9.33	-1.1%	1.829	1.874
2500.312	2.277	2.277	-0.000 ( -0.0% )	9.37	9.48	-1.2%	1.823	1.865
2500.33	1.100	1.098	0.002 ( +0.2% )	21.91	20.93	+4.7%	1.641	1.638
2500.331	1.394	1.393	0.001 ( +0.1% )	16.15	15.93	+1.4%	1.790	1.790
2500.332	1.326	1.324	0.002 ( +0.1% )	17.72	18.22	-2.8%	1.847	1.849
2500.401	2.139	2.138	0.000 ( +0.0% )	10.46	10.35	+1.1%	1.158	1.193
2500.501	1.711	1.711	0.000 ( +0.0% )	16.47	16.70	-1.4%	1.072	1.111
2500.511	1.124	1.123	0.002 ( +0.2% )	30.04	30.41	-1.2%	1.327	1.362
2500.601	2.050	2.050	0.000 ( +0.0% )	12.51	12.48	+0.2%	1.131	1.170

swertz · 2023-02-08T12:51:41Z

+1

Many more photon trigger objects selected, with the new filters (varying depending on the era):

cmsbuild · 2023-02-08T12:52:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-02-08T14:13:33Z

+1

Expected changes are observed in the DQM plots.

diphoton_hlt_filters_added

3547eea

cmsbuild added this to the CMSSW_13_0_X milestone Feb 7, 2023

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Feb 7, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 7, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 7, 2023

cmsbuild added tests-rejected and removed tests-started labels Feb 7, 2023

cmsbuild added tests-started and removed tests-rejected labels Feb 7, 2023

cmsbuild added the egamma label Feb 7, 2023

cmsbuild added tests-rejected and removed tests-started labels Feb 7, 2023

cmsbuild removed the tests-rejected label Feb 8, 2023

cmsbuild added the tests-started label Feb 8, 2023

cmsbuild added tests-approved and removed tests-started labels Feb 8, 2023

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Feb 8, 2023

cmsbuild added orp-approved and removed orp-pending labels Feb 8, 2023

cmsbuild merged commit e22dce1 into cms-sw:master Feb 8, 2023

swagata87 mentioned this pull request Mar 1, 2023

eg hlt filter threshold reduction to 15 \GeV from 20\GeV #40909

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

diphoton_hlt_filters_added #40711

diphoton_hlt_filters_added #40711

Soumyatifr commented Feb 7, 2023 •

edited

cmsbuild commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

swertz commented Feb 7, 2023

Soumyatifr commented Feb 7, 2023

swertz commented Feb 7, 2023

swertz commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

swertz commented Feb 7, 2023

swertz commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

swertz commented Feb 8, 2023

cmsbuild commented Feb 8, 2023

swertz commented Feb 8, 2023

cmsbuild commented Feb 8, 2023

rappoccio commented Feb 8, 2023

diphoton_hlt_filters_added #40711

diphoton_hlt_filters_added #40711

Conversation

Soumyatifr commented Feb 7, 2023 • edited

cmsbuild commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

swertz commented Feb 7, 2023

Soumyatifr commented Feb 7, 2023

swertz commented Feb 7, 2023

swertz commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

RelVals-INPUT

Comparison Summary

NANO Comparison Summary

swertz commented Feb 7, 2023

swertz commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

RelVals-INPUT

Comparison Summary

NANO Comparison Summary

swertz commented Feb 8, 2023

cmsbuild commented Feb 8, 2023

Comparison Summary

NANO Comparison Summary

swertz commented Feb 8, 2023

cmsbuild commented Feb 8, 2023

rappoccio commented Feb 8, 2023

Soumyatifr commented Feb 7, 2023 •

edited