stop using bare ROOT objects in HLTDQMHist* classes [13_0_X]

[missirol]

backport of #40760

PR description:

From the description of #40760:

This PR tries to implement the suggestion in #40676 (comment), to avoid accessing bare ROOT objects (via MonitorElement) in the HLTDQMHist*D classes of the HLT offline DQM.

Minor cleanup is also applied to HLTTagAndProbeOfflineSource<..>::fillDescriptions.

Merely technical. No changes expected.

PR validation:

None beyond the checks done for #40760.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#40760

Backport of a possible fix to address #40676.

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

• DQMOffline/Trigger (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from stop using bare ROOT objects in HLTDQMHist* classes #40760

[missirol]

type bugfix

[missirol]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2532d/30661/summary.html
COMMIT: a8455d4
CMSSW: CMSSW_13_0_X_2023-02-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40784/30661/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

• 11834.011834.0_TTbar_14TeV+2021PU/step2_TTbar_14TeV+2021PU.log

Comparison Summary

Summary:

• You potentially removed 25 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3556272
• DQMHistoTests: Total failures: 108
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3556142
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2532d/30694/summary.html
COMMIT: a8455d4
CMSSW: CMSSW_13_0_X_2023-02-16-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40784/30694/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 22 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3556272
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3556241
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1