Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add double PFTau HLT filter #40824

Merged
merged 1 commit into from Feb 21, 2023
Merged

Conversation

covarell
Copy link
Contributor

@covarell covarell commented Feb 20, 2023

PR description:

Just add a new alias for a PFTau-PFTau doublet filter in HLT. Needed for a new W->3pi HLT path.

PR validation:

Just verified scram compilation and used in HLT (no modification of existing code).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to 13_0_X is #40823, needed in order to use HLT paths in 2023 online.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @covarell (Roberto Covarelli) for CMSSW_12_6_X.

It involves the following packages:

  • HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40824/34279

  • This PR adds an extra 12KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@missirol
Copy link
Contributor

needed in CMSSW 12 in order to use HLT paths in 2023 online

@covarell , the online menus for 2023 will be in 13_0_X or higher. Why does this need to be backported to 12_6_X ?

@covarell covarell changed the base branch from CMSSW_12_6_X to master February 20, 2023 21:38
@cmsbuild cmsbuild modified the milestones: CMSSW_12_6_X, CMSSW_13_1_X Feb 20, 2023
@covarell
Copy link
Contributor Author

Thanks @missirol , I have rebased to master since this is needed anyway for the 13.X backport @Martin-Grunewald

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e0d13/30768/summary.html
COMMIT: 6a81204
CMSSW: CMSSW_13_1_X_2023-02-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40824/30768/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 17 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529029
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528998
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

@covarell , just for clarity, can you please add "HLT" to the PR title? e.g. "add double PFTau HLT filter"

Also, this part of the PR description

Backport of #40823, needed in CMSSW 12 in order to use HLT paths in 2023 online.

should be removed, as this is now the PR to master. You could instead add a similar comment to the description of #40823.

@missirol
Copy link
Contributor

+hlt

  • addition of a new HLT filter, not currently used in any central wfs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta perrotta changed the title add double PFTau filter add double PFTau HLT filter Feb 21, 2023
@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 39e1a0a into cms-sw:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants