Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert FwdPtrProducer to stream Producer #4083

Merged
merged 1 commit into from Jun 3, 2014

Conversation

Dr15Jones
Copy link
Contributor

Static analyzer and helgrind show it is safe to convert this class
to be a stream based Producer. Thread performance analysis showed
this conversion is needed for efficient threading.

Static analyzer and helgrind show it is safe to convert this class
to be a stream based Producer. Thread performance analysis showed
this conversion is needed for efficient threading.
@Dr15Jones
Copy link
Contributor Author

This change is purely technical and will have no effect on single-threaded running.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Convert FwdPtrProducer to stream Producer

It involves the following packages:

CommonTools/UtilAlgos

@nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2014

+1

for #4083 b0711d0

for this and other flips-flops to and from stream module RECO signatures can be bypassed

ktf added a commit that referenced this pull request Jun 3, 2014
Convert FwdPtrProducer to stream Producer.
@ktf ktf merged commit 5ee758a into cms-sw:CMSSW_7_1_X Jun 3, 2014
@Dr15Jones Dr15Jones deleted the makeFwdPtrProducerStreamModule branch June 12, 2014 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants