Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex154B Fix the issue of 2026D91 which can now work in the dd4hep version #40838

Merged
merged 2 commits into from Feb 23, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Feb 21, 2023

PR description:

Fix the issue of 2026D91 which can now work in the dd4hep version. In the earlier version, any cmdim job with this scenario and dd4hep used to crash in the very first event with
----- Begin Fatal Exception 21-Feb-2023 12:20:44 CET-----------------------
An exception of category 'NoProxyException' occurred while
[0] Processing global begin Run run: 1
[1] Prefetching for module OscarMTProducer/'g4SimHits'
[2] Calling method for EventSetup module TrackerGeometricDetESModule/'trackerNumberingGeometry'
Exception Message:
No data of type "DDCompactView" with label "" in record "IdealGeometryRecord"

Now the dd4hep job with that scenario runs normally

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Need to be back ported to 13_0_X

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40838/34292

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Geometry/HcalCommonData (geometry)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

@bsunanda could you please add to the description what is the issue that this PR is fixing?
I.e. why D91 was not able to work with dd4hep, and what this PR fixes in practice to allow it?

@srimanob
Copy link
Contributor

please abort

@srimanob
Copy link
Contributor

test parameters:

  • workflow = 22034.911

@srimanob
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0517d/30782/summary.html
COMMIT: 21d049a
CMSSW: CMSSW_13_1_X_2023-02-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40838/30782/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 22034.911

@srimanob
Copy link
Contributor

test parameters:

@srimanob
Copy link
Contributor

test parameters:

  • workflow = 22034.911
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano

@srimanob
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

Pull request #40838 was updated. @perrotta, @rappoccio, @Dr15Jones, @bsunanda, @makortel, @civanch, @mdhildreth, @AdrianoDee, @srimanob, @fabiocos, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@srimanob As you see it was in GeometryConf.py

@bsunanda
Copy link
Contributor Author

@srimanob please uphold this and put it as a bug fix. Like to backport this to 13_0

@srimanob
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Feb 23, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0517d/30831/summary.html
COMMIT: 3056383
CMSSW: CMSSW_13_1_X_2023-02-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40838/30831/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 163 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528709
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528684
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Feb 23, 2023

+1

@civanch
Copy link
Contributor

civanch commented Feb 23, 2023

type bug-fix

@bsunanda
Copy link
Contributor Author

@srimanob please approve this PR

@srimanob
Copy link
Contributor

+Upgrade

@bsunanda
Copy link
Contributor Author

@perrotta @rappoccio Please approve and integrate this bug fix. Need to backport this to 13_0_X

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 4b75725 into cms-sw:master Feb 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants