Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug printouts for MTD in several packages, fix simulation LogDebug #40845

Merged
merged 1 commit into from Feb 22, 2023

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Feb 22, 2023

PR description:

This PR updates a number of debug printout statements in several reconstruction and simulation packages. There updates are used in MTD-related developments.

PR validation:

Code compiles and runs, if activated. The update in SimG4Core/Notification is needed to get the code compiling, since the original version produces:

/gpfs/cms/users/cossutti/Timing/digi/CMSSW_13_0_0_pre4/src/SimG4Core/Notification/src/SimTrackManager.cc: In member function 'void SimTrackManager::cleanTracksWithHistory()':
/gpfs/cms/users/cossutti/Timing/digi/CMSSW_13_0_0_pre4/src/SimG4Core/Notification/src/SimTrackManager.cc:344:23: error: expected ';' before '<' token
  344 |   for (unsigned int it < (*m_trksForThisEvent).size(); ++it) {
      |                       ^~
      |                       ;
/gpfs/cms/users/cossutti/Timing/digi/CMSSW_13_0_0_pre4/src/SimG4Core/Notification/src/SimTrackManager.cc:344:24: error: expected primary-expression before '<' token
  344 |   for (unsigned int it < (*m_trksForThisEvent).size(); ++it) {
      |                        ^
gmake: *** [config/SCRAM/GMake/Makefile.rules:1740: tmp/el8_amd64_gcc11/src/SimG4Core/Notification/src/SimG4CoreNotification/SimTrackManager.cc.o] Error 1
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40845/34298

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

  • RecoLocalFastTime/FTLCommonAlgos (upgrade, reconstruction)
  • RecoMTD/DetLayers (upgrade, reconstruction)
  • RecoMTD/TrackExtender (upgrade, reconstruction)
  • SimFastTiming/FastTimingCommon (upgrade, simulation)
  • SimG4Core/Notification (simulation)

@civanch, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth, @mandrenguyen can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere, @slomeo, @bsunanda this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

nothing will be really tested...

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05791d/30806/summary.html
COMMIT: 44d647a
CMSSW: CMSSW_13_1_X_2023-02-21-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40845/30806/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528709
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528684
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

1 similar comment
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05791d/30806/summary.html
COMMIT: 44d647a
CMSSW: CMSSW_13_1_X_2023-02-21-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40845/30806/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528709
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528684
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

Technical PR on printout, LogTrace, LogDebug.

@mandrenguyen
Copy link
Contributor

+reconstruction

@civanch
Copy link
Contributor

civanch commented Feb 22, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants