New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLT Phase2 Removing Duplicate Modules #40912
HLT Phase2 Removing Duplicate Modules #40912
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40912/34392
|
A new Pull Request was created by @beaucero for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beaucero , I think some changes are necessary.
HLTrigger/Configuration/python/HLT_75e33/psets/TrackAssociatorParameters_cfi.py
Outdated
Show resolved
Hide resolved
HLTrigger/Configuration/python/HLT_75e33/tasks/ecalDigisTask_cfi.py
Outdated
Show resolved
Hide resolved
please abort Tests didn't really start anyway. Better to clarify the review comments, first. |
de8d62a
to
40d9d46
Compare
@cmsbuild, please test workflow 20834.76 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40912/34590
|
Pull request #40912 was updated. @Martin-Grunewald, @missirol can you please check and sign again. |
Corrections on the previous PR. Now everything should be OK: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave some comments on the latest version.
Since Upgrade maintains this menu, I can sign the PR even if these comments are not addressed, as long as the tests pass.
HLTrigger/Configuration/python/HLT_75e33/psets/TrackAssociatorParameters_cfi.py
Outdated
Show resolved
Hide resolved
HLTrigger/Configuration/python/HLT_75e33/tasks/ecalDigisTask_cfi.py
Outdated
Show resolved
Hide resolved
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40912/34601
|
Pull request #40912 was updated. @Martin-Grunewald, @missirol can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40611c/31251/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
I would say that this one can go ahead, while we decide what to do about the changes in #41047 . |
Okay, thanks. @cms-sw/orp-l2 , this is ready for your review. |
+1 |
PR description:
Some modules in HLT Phase2 menu are duplicated leading to a non optimum CPU usage. The duplicate modules are now removed and inputTag changed accordingly
See the presentation (only the 15 modules on the 2nd page have been worked on): https://indico.cern.ch/event/1259059/contributions/5288699/attachments/2601695/4492493/SB_RemovalDuplicate27Feb2023.pdf
PR validation:
Running Phase2 menu after the removal of the modules