Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD validation: ETL digi per LGAD multiplicity monitoring #40913

Merged
merged 1 commit into from Mar 3, 2023

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Mar 1, 2023

PR description:

Addition of four plots to the MTD validation, to monitor the DIGI multiplicity per LGAD sensor in the ETL. An LGAD could potentially fire one digi per pad, exceeding the histogram range. This range has been adjusted on the observed multiplicty in PU200 events, with a safety margin, to save space.

PR validation:

Code compiles, runs, and produces the desired output.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40913/34393

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2023

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

  • Validation/MtdValidation (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 1, 2023

please test

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 1, 2023

@parbol @ctarricone FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d53fca/30967/summary.html
COMMIT: 7e6daad
CMSSW: CMSSW_13_1_X_2023-02-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40913/30967/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 25 lines from the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529699
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 28
  • DQMHistoTests: Total successes: 3529646
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 6.727 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 20834.0,... ): 0.961 KiB MTD/ETL
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 3, 2023

+1

@cmsbuild cmsbuild merged commit eefabb6 into cms-sw:master Mar 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants